From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:45090 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751304AbeCQNYK (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 17 Mar 2018 09:24:10 -0400
Date: Sat, 17 Mar 2018 09:24:06 -0400 (EDT)
Message-Id: <20180317.092406.1395846063616448715.davem@davemloft.net>
To: sonnyrao@chromium.org
Cc: netdev@vger.kernel.org
Subject: Re: [v2] vhost: add vsock compat ioctl
From: David Miller <davem@davemloft.net>
In-Reply-To: <CAPz6YkX8SZVOFyOAdhrotvQ7MtGYnuzb_=+tSfX6jB+rvQm2_w@mail.gmail.com>
References: <20180316.153018.1513048030981683655.davem@davemloft.net>
        <CAPz6YkX8SZVOFyOAdhrotvQ7MtGYnuzb_=+tSfX6jB+rvQm2_w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Sonny Rao <sonnyrao@chromium.org>
Date: Fri, 16 Mar 2018 17:54:12 -0700

> On Fri, Mar 16, 2018 at 12:30 PM, David Miller <davem@davemloft.net> wrote:
>>
>> Although the top level ioctls are probably size and layout compatible,
>> I do not think that the deeper ioctls can be called by compat binaries
>> without some translations in order for them to work.
> 
> Ok, thanks -- I have only tested VHOST_VSOCK_SET_GUEST_CID and
> VHOST_VSOCK_SET_RUNNING but by deeper ioctls I think you might mean
> the ioctls under vhost_dev_ioctl() and vhost_vring_ioctl()?

Yes.