From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:48524 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752577AbeCQUzF (ORCPT ); Sat, 17 Mar 2018 16:55:05 -0400 Date: Sat, 17 Mar 2018 16:54:58 -0400 (EDT) Message-Id: <20180317.165458.1452469008226572576.davem@davemloft.net> To: alexander.duyck@gmail.com Cc: willy@infradead.org, alexander.h.duyck@intel.com, linux-mm@vger.kernel.org, netdev@vger.kernel.org, mawilcox@microsoft.com Subject: Re: [RFC 2/2] page_frag_cache: Store metadata in struct page From: David Miller In-Reply-To: References: <20180315195329.7787-1-willy@infradead.org> <20180315195329.7787-3-willy@infradead.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Alexander Duyck Date: Thu, 15 Mar 2018 14:26:28 -0700 > So my concern with this patch is that it is essentially trading off > CPU performance for reduced size. One of the reasons for getting away > from using the page pointer is because it is expensive to access the > page when the ref_count is bouncing on multiple cache lines. Agreed.