From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:48590 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbeCQVBl (ORCPT ); Sat, 17 Mar 2018 17:01:41 -0400 Date: Sat, 17 Mar 2018 17:01:40 -0400 (EDT) Message-Id: <20180317.170140.992336177542785792.davem@davemloft.net> To: felix.manlunas@cavium.com Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com, derek.chickles@cavium.com, satananda.burla@cavium.com Subject: Re: [PATCH net-next] liquidio: Allow RX descriptors to be consumed before disabling NAPI. From: David Miller In-Reply-To: <20180314231747.GA1263@felix-thinkpad.cavium.com> References: <20180314231747.GA1263@felix-thinkpad.cavium.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Felix Manlunas Date: Wed, 14 Mar 2018 16:17:47 -0700 > From: Raghu Vatsavayi > > Signed-off-by: Raghu Vatsavayi > Acked-by: Derek Chickles > Signed-off-by: Felix Manlunas This must have a reasonable commit message added, and that commit message must explain in detail what exactly is happening here. But since I did read the patch I do not think that doing a looping sleeping read is the way to fix this problem. Instead, you should find some way to wait on the specific event that needs to occur.