* [PATCH net-next] cxgb4: Fix queue free path of ULD drivers
@ 2018-03-15 12:04 Ganesh Goudar
2018-03-17 21:20 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ganesh Goudar @ 2018-03-15 12:04 UTC (permalink / raw)
To: netdev, davem
Cc: nirranjan, indranil, venkatesh, Arjun Vynipadath, Casey Leedom,
Ganesh Goudhar
From: Arjun Vynipadath <arjun@chelsio.com>
Setting sge_uld_rxq_info to NULL in free_queues_uld().
We are referencing sge_uld_rxq_info in cxgb_up(). This
will fix a panic when interface is brought up after a
ULDq creation failure.
Fixes: 94cdb8bb993a (cxgb4: Add support for dynamic allocation
of resources for ULD)
Signed-off-by: Arjun Vynipadath <arjun@chelsio.com>
Signed-off-by: Casey Leedom <leedom@chelsio.com>
Signed-off-by: Ganesh Goudhar <ganeshgr@chelsio.com>
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
index 6b5fea4..2d82714 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
@@ -342,6 +342,7 @@ static void free_queues_uld(struct adapter *adap, unsigned int uld_type)
{
struct sge_uld_rxq_info *rxq_info = adap->sge.uld_rxq_info[uld_type];
+ adap->sge.uld_rxq_info[uld_type] = NULL;
kfree(rxq_info->rspq_id);
kfree(rxq_info->uldrxq);
kfree(rxq_info);
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] cxgb4: Fix queue free path of ULD drivers
2018-03-15 12:04 [PATCH net-next] cxgb4: Fix queue free path of ULD drivers Ganesh Goudar
@ 2018-03-17 21:20 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-03-17 21:20 UTC (permalink / raw)
To: ganeshgr; +Cc: netdev, nirranjan, indranil, venkatesh, arjun, leedom
From: Ganesh Goudar <ganeshgr@chelsio.com>
Date: Thu, 15 Mar 2018 17:34:14 +0530
> From: Arjun Vynipadath <arjun@chelsio.com>
>
> Setting sge_uld_rxq_info to NULL in free_queues_uld().
> We are referencing sge_uld_rxq_info in cxgb_up(). This
> will fix a panic when interface is brought up after a
> ULDq creation failure.
>
> Fixes: 94cdb8bb993a (cxgb4: Add support for dynamic allocation
> of resources for ULD)
> Signed-off-by: Arjun Vynipadath <arjun@chelsio.com>
> Signed-off-by: Casey Leedom <leedom@chelsio.com>
> Signed-off-by: Ganesh Goudhar <ganeshgr@chelsio.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-17 21:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-15 12:04 [PATCH net-next] cxgb4: Fix queue free path of ULD drivers Ganesh Goudar
2018-03-17 21:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).