From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2 net 1/2] vmxnet3: avoid xmit reset due to a race in vmxnet3 Date: Sat, 17 Mar 2018 20:05:06 -0400 (EDT) Message-ID: <20180317.200506.1922029560822089854.davem@davemloft.net> References: <20180316214754.20650-1-doshir@vmware.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, ntanaka@vmware.com, skhare@vmware.com, pv-drivers@vmware.com, linux-kernel@vger.kernel.org To: doshir@vmware.com Return-path: In-Reply-To: <20180316214754.20650-1-doshir@vmware.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Ronak Doshi Date: Fri, 16 Mar 2018 14:47:54 -0700 > The field txNumDeferred is used by the driver to keep track of the number > of packets it has pushed to the emulation. The driver increments it on > pushing the packet to the emulation and the emulation resets it to 0 at > the end of the transmit. > > There is a possibility of a race either when (a) ESX is under heavy load or > (b) workload inside VM is of low packet rate. > > This race results in xmit hangs when network coalescing is disabled. This > change creates a local copy of txNumDeferred and uses it to perform ring > arithmetic. > > Reported-by: Noriho Tanaka > Signed-off-by: Ronak Doshi > Acked-by: Shrikrishna Khare Applied.