From: Christian Brauner <christian.brauner@canonical.com>
To: David Miller <davem@davemloft.net>
Cc: christian.brauner@ubuntu.com, ebiederm@xmission.com,
gregkh@linuxfoundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, serge@hallyn.com,
avagin@virtuozzo.com, ktkhai@virtuozzo.com
Subject: Re: [PATCH v2] netns: send uevent messages
Date: Sat, 17 Mar 2018 11:29:03 +0100 [thread overview]
Message-ID: <20180317102902.GA4301@gmail.com> (raw)
In-Reply-To: <20180316.144145.1695554148709004295.davem@davemloft.net>
On Fri, Mar 16, 2018 at 02:41:45PM -0400, David Miller wrote:
> From: Christian Brauner <christian.brauner@ubuntu.com>
> Date: Fri, 16 Mar 2018 13:50:30 +0100
>
> > +static int uevent_net_broadcast(struct sock *usk, struct sk_buff *skb,
> > + struct netlink_ext_ack *extack)
> > +{
> > + int ret;
> > + /* u64 to chars: 2^64 - 1 = 21 chars */
> > + char buf[sizeof("SEQNUM=") + 21];
> > + struct sk_buff *skbc;
>
> I hate to be difficult, but please use reverse christmas tree ordering
> for local variables.
No problem David, coding style is important. I'm about to send out
another version with:
/* u64 to chars: 2^64 - 1 = 21 chars */
char buf[sizeof("SEQNUM=") + 21];
struct sk_buff *skbc;
int ret;
Thanks!
Christian
>
> > +static int uevent_net_rcv_skb(struct sk_buff *skb, struct nlmsghdr *nlh,
> > + struct netlink_ext_ack *extack)
> > +{
> > + int ret;
> > + struct net *net;
>
> Likewise.
>
> Thank you.
next prev parent reply other threads:[~2018-03-17 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 12:50 [PATCH v2] netns: send uevent messages Christian Brauner
2018-03-16 18:41 ` David Miller
2018-03-17 10:29 ` Christian Brauner [this message]
2018-03-16 20:14 ` Kirill Tkhai
2018-03-17 10:31 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180317102902.GA4301@gmail.com \
--to=christian.brauner@canonical.com \
--cc=avagin@virtuozzo.com \
--cc=christian.brauner@ubuntu.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).