From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp2120.oracle.com ([141.146.126.78]:38412 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751097AbeCQV0R (ORCPT ); Sat, 17 Mar 2018 17:26:17 -0400 Date: Sat, 17 Mar 2018 17:26:00 -0400 From: Sowmini Varadhan To: Kirill Tkhai Cc: rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, edumazet@google.com, davem@davemloft.net Subject: Re: [rds-devel] [PATCH RFC RFC] rds: Use NETDEV_UNREGISTER in rds_tcp_dev_event() (then kill NETDEV_UNREGISTER_FINAL) Message-ID: <20180317212553.GA16416@oracle.com> References: <152120385651.2065.2567466917573907029.stgit@localhost.localdomain> <20180316130008.GE16870@oracle.com> <512c2483-aa62-b385-6079-1b6ff8ba4636@virtuozzo.com> <20180316172918.GM16870@oracle.com> <82d6e954-8043-078c-266c-2f1ac992f864@virtuozzo.com> <20180317141507.GC873@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180317141507.GC873@oracle.com> Sender: netdev-owner@vger.kernel.org List-ID: On (03/17/18 10:15), Sowmini Varadhan wrote: > To solve the scaling problem why not just have a well-defined > callback to modules when devices are quiesced, instead of > overloading the pernet_device registration in this obscure way? I thought about this a bit, and maybe I missed your original point- today we are able to do all the needed cleanup for rds-tcp when we unload the module, even though network activity has not quiesced, and there is no reason we cannot use the same code for netns cleanup as well. I think this is what you were trying to ask, when you said "why do you need to know that loopback is down?" I'm sorry I missed that, I will re-examine the code and get back to you- it should be possible to just do one registration and cleanup rds-state and avoid the hack of registering twice (saw your most recent long mail- sorry- both v1 and v2 are hacks) I'm on the road at the moment, so I'll get back to you on this. Thanks --Sowmini