* [PATCH net] net: fec: Fix unbalanced PM runtime calls
@ 2018-03-18 19:49 Florian Fainelli
2018-03-18 20:35 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Florian Fainelli @ 2018-03-18 19:49 UTC (permalink / raw)
To: netdev; +Cc: davem, andrew, l.stach, Florian Fainelli, Fugang Duan, open list
When unbinding/removing the driver, we will run into the following warnings:
[ 259.655198] fec 400d1000.ethernet: 400d1000.ethernet supply phy not found, using dummy regulator
[ 259.665065] fec 400d1000.ethernet: Unbalanced pm_runtime_enable!
[ 259.672770] fec 400d1000.ethernet (unnamed net_device) (uninitialized): Invalid MAC address: 00:00:00:00:00:00
[ 259.683062] fec 400d1000.ethernet (unnamed net_device) (uninitialized): Using random MAC address: f2:3e:93:b7:29:c1
[ 259.696239] libphy: fec_enet_mii_bus: probed
Avoid these warnings by balancing the runtime PM calls during fec_drv_remove().
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/ethernet/freescale/fec_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 7a7f3a42b2aa..d4604bc8eb5b 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -3600,6 +3600,8 @@ fec_drv_remove(struct platform_device *pdev)
fec_enet_mii_remove(fep);
if (fep->reg_phy)
regulator_disable(fep->reg_phy);
+ pm_runtime_put(&pdev->dev);
+ pm_runtime_disable(&pdev->dev);
if (of_phy_is_fixed_link(np))
of_phy_deregister_fixed_link(np);
of_node_put(fep->phy_node);
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: fec: Fix unbalanced PM runtime calls
2018-03-18 19:49 [PATCH net] net: fec: Fix unbalanced PM runtime calls Florian Fainelli
@ 2018-03-18 20:35 ` David Miller
2018-03-18 21:42 ` Florian Fainelli
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2018-03-18 20:35 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, andrew, l.stach, fugang.duan, linux-kernel
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Sun, 18 Mar 2018 12:49:51 -0700
> When unbinding/removing the driver, we will run into the following warnings:
>
> [ 259.655198] fec 400d1000.ethernet: 400d1000.ethernet supply phy not found, using dummy regulator
> [ 259.665065] fec 400d1000.ethernet: Unbalanced pm_runtime_enable!
> [ 259.672770] fec 400d1000.ethernet (unnamed net_device) (uninitialized): Invalid MAC address: 00:00:00:00:00:00
> [ 259.683062] fec 400d1000.ethernet (unnamed net_device) (uninitialized): Using random MAC address: f2:3e:93:b7:29:c1
> [ 259.696239] libphy: fec_enet_mii_bus: probed
>
> Avoid these warnings by balancing the runtime PM calls during fec_drv_remove().
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thank you.
Queue this up for -stable?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: fec: Fix unbalanced PM runtime calls
2018-03-18 20:35 ` David Miller
@ 2018-03-18 21:42 ` Florian Fainelli
2018-03-19 0:12 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Florian Fainelli @ 2018-03-18 21:42 UTC (permalink / raw)
To: David Miller; +Cc: netdev, andrew, l.stach, fugang.duan, linux-kernel
On 03/18/2018 01:35 PM, David Miller wrote:
> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Sun, 18 Mar 2018 12:49:51 -0700
>
>> When unbinding/removing the driver, we will run into the following warnings:
>>
>> [ 259.655198] fec 400d1000.ethernet: 400d1000.ethernet supply phy not found, using dummy regulator
>> [ 259.665065] fec 400d1000.ethernet: Unbalanced pm_runtime_enable!
>> [ 259.672770] fec 400d1000.ethernet (unnamed net_device) (uninitialized): Invalid MAC address: 00:00:00:00:00:00
>> [ 259.683062] fec 400d1000.ethernet (unnamed net_device) (uninitialized): Using random MAC address: f2:3e:93:b7:29:c1
>> [ 259.696239] libphy: fec_enet_mii_bus: probed
>>
>> Avoid these warnings by balancing the runtime PM calls during fec_drv_remove().
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Applied, thank you.
>
> Queue this up for -stable?
I would be inclined to say yes, it was not exactly easy to track down a
set of commits, since this was changed quite a bit.
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: fec: Fix unbalanced PM runtime calls
2018-03-18 21:42 ` Florian Fainelli
@ 2018-03-19 0:12 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-03-19 0:12 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, andrew, l.stach, fugang.duan, linux-kernel
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Sun, 18 Mar 2018 14:42:22 -0700
> On 03/18/2018 01:35 PM, David Miller wrote:
>> Queue this up for -stable?
>
> I would be inclined to say yes, it was not exactly easy to track down a
> set of commits, since this was changed quite a bit.
Ok, queued up.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-19 0:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-18 19:49 [PATCH net] net: fec: Fix unbalanced PM runtime calls Florian Fainelli
2018-03-18 20:35 ` David Miller
2018-03-18 21:42 ` Florian Fainelli
2018-03-19 0:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).