From: Igor Pylypiv <ipylypiv@silver-peak.com>
To: David Miller <davem@davemloft.net>
Cc: skhare@vmware.com, pv-drivers@vmware.com, netdev@vger.kernel.org
Subject: Re: [PATCH] vmxnet3: fix LRO feature check
Date: Sat, 17 Mar 2018 18:08:47 -0700 [thread overview]
Message-ID: <20180318010846.GA3059@silver-peak.com> (raw)
In-Reply-To: <20180317.202032.2223279074951132662.davem@davemloft.net>
The 03/17/2018 20:20, David Miller wrote:
> From: Igor Pylypiv <ipylypiv@silver-peak.com>
> Date: Sat, 17 Mar 2018 00:58:52 -0700
>
> > rxcsum and lro fields were deleted in commit a0d2730c9571 ("net: vmxnet3:
> > convert to hw_features"). With upgrading to newer version those fields were
> > resurrected and new code started using uninitialized lro field.
> > Removing rxcsum and lro fields.
> >
> > Fixes: 45dac1d6ea04 ("vmxnet3: Changes for vmxnet3 adapter version 2 (fwd)")
> > Signed-off-by: Igor Pylypiv <ipylypiv@silver-peak.com>
>
> Why are you posting this again?
>
> I applied the copy of this patch which was part of a two part series
> posted earlier.
No way!!!
I know it is hard to believe but I found this bug myself.
That's really odd. I took linux-next-20180316 and patch wasn't there.
Now I see the patch in your tree.
Anyway, let me send another one to delete rxcsum at least...
next prev parent reply other threads:[~2018-03-18 1:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-17 7:58 [PATCH] vmxnet3: fix LRO feature check Igor Pylypiv
2018-03-18 0:20 ` David Miller
2018-03-18 1:08 ` Igor Pylypiv [this message]
2018-03-18 6:37 ` kbuild test robot
2018-03-20 14:57 ` David Miller
2018-03-20 18:24 ` Igor Pylypiv
2018-03-20 18:42 ` Shrikrishna Khare
2018-03-20 18:59 ` David Miller
2018-03-18 11:23 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180318010846.GA3059@silver-peak.com \
--to=ipylypiv@silver-peak.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=skhare@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).