From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-cys01nam02on0105.outbound.protection.outlook.com ([104.47.37.105]:50547 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752141AbeCRBI7 (ORCPT ); Sat, 17 Mar 2018 21:08:59 -0400 Date: Sat, 17 Mar 2018 18:08:47 -0700 From: Igor Pylypiv To: David Miller Cc: skhare@vmware.com, pv-drivers@vmware.com, netdev@vger.kernel.org Subject: Re: [PATCH] vmxnet3: fix LRO feature check Message-ID: <20180318010846.GA3059@silver-peak.com> References: <20180317075852.11785-1-ipylypiv@silver-peak.com> <20180317.202032.2223279074951132662.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180317.202032.2223279074951132662.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: The 03/17/2018 20:20, David Miller wrote: > From: Igor Pylypiv > Date: Sat, 17 Mar 2018 00:58:52 -0700 > > > rxcsum and lro fields were deleted in commit a0d2730c9571 ("net: vmxnet3: > > convert to hw_features"). With upgrading to newer version those fields were > > resurrected and new code started using uninitialized lro field. > > Removing rxcsum and lro fields. > > > > Fixes: 45dac1d6ea04 ("vmxnet3: Changes for vmxnet3 adapter version 2 (fwd)") > > Signed-off-by: Igor Pylypiv > > Why are you posting this again? > > I applied the copy of this patch which was part of a two part series > posted earlier. No way!!! I know it is hard to believe but I found this bug myself. That's really odd. I took linux-next-20180316 and patch wasn't there. Now I see the patch in your tree. Anyway, let me send another one to delete rxcsum at least...