From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f177.google.com ([209.85.216.177]:46296 "EHLO mail-qt0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750766AbeCRSgk (ORCPT ); Sun, 18 Mar 2018 14:36:40 -0400 Received: by mail-qt0-f177.google.com with SMTP id h4so10065141qtn.13 for ; Sun, 18 Mar 2018 11:36:40 -0700 (PDT) Date: Sun, 18 Mar 2018 15:36:36 -0300 From: Marcelo Ricardo Leitner To: David Ahern Cc: netdev@vger.kernel.org, Alexander Aring , Jiri Pirko , Jakub Kicinski Subject: Re: [PATCH RFC 0/2] Add support for warnings to extack Message-ID: <20180318183636.GI9345@localhost.localdomain> References: <5f894da5-6e45-c70c-e061-e7572a4390f1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f894da5-6e45-c70c-e061-e7572a4390f1@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, Mar 18, 2018 at 10:11:52AM -0600, David Ahern wrote: > On 3/16/18 1:23 PM, Marcelo Ricardo Leitner wrote: > > Currently we have the limitation that warnings cannot be reported though > > extack. For example, when tc flower failed to get offloaded but got > > installed on software datapath. The hardware failure is not fatal and > > thus extack is not even shared with the driver, so the error is simply > > omitted from any logging. > > If this set ends up moving forward, the above statement needs to be > corrected: extack allows non-error messages to be sent back to the user, > so the above must be talking about some other limitation local to tc. I'll split this patchset into two: - pass extack to drivers when doing tc offload (such as flower and others) and allow reporting of warnings in such cases. (according to a opt-in flag, as discussed in the other subthread) - allow more than one message The 1st may lead to the 2nd but right now it's more as a supposition, as there is no actual user for it yet.