From: Sabrina Dubroca <sd@queasysnail.net>
To: Atul Gupta <atul.gupta@chelsio.com>
Cc: davejwatson@fb.com, davem@davemloft.net,
herbert@gondor.apana.org.au, sbrivio@redhat.com,
linux-crypto@vger.kernel.org, netdev@vger.kernel.org,
ganeshgr@chelsio.com
Subject: Re: [PATCH v11 crypto 06/12] crypto: chtls - structure and macro for Inline TLS
Date: Sun, 18 Mar 2018 23:53:37 +0100 [thread overview]
Message-ID: <20180318225337.GA19891@bistromath.localdomain> (raw)
In-Reply-To: <1521214661-28928-6-git-send-email-atul.gupta@chelsio.com>
2018-03-16, 21:07:35 +0530, Atul Gupta wrote:
[...]
> +#define SOCK_INLINE (31)
[...]
> +static inline int csk_flag(const struct sock *sk, enum csk_flags flag)
> +{
> + struct chtls_sock *csk = rcu_dereference_sk_user_data(sk);
> +
> + if (!sock_flag(sk, SOCK_INLINE))
> + return 0;
> + return test_bit(flag, &csk->flags);
> +}
Should drivers really start defining their own socket flags?
> +static inline void set_queue(struct sk_buff *skb,
> + unsigned int queue, const struct sock *sk)
> +{
> + skb->queue_mapping = queue;
> +}
That's skb_set_queue_mapping(), no need to define your own.
--
Sabrina
next prev parent reply other threads:[~2018-03-18 22:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 15:37 [PATCH v11 crypto 01/12] tls: support for Inline tls record Atul Gupta
2018-03-16 15:37 ` [PATCH v11 crypto 02/12] ethtool: enable Inline TLS in HW Atul Gupta
2018-03-16 15:37 ` [PATCH v11 crypto 03/12] cxgb4: Inline TLS FW Interface Atul Gupta
2018-03-16 15:37 ` [PATCH v11 crypto 04/12] cxgb4: LLD driver changes to support TLS Atul Gupta
2018-03-16 15:37 ` [PATCH v11 crypto 05/12] crypto: chcr - Inline TLS Key Macros Atul Gupta
2018-03-16 15:37 ` [PATCH v11 crypto 06/12] crypto: chtls - structure and macro for Inline TLS Atul Gupta
2018-03-18 22:53 ` Sabrina Dubroca [this message]
2018-03-19 3:22 ` Atul Gupta
2018-03-16 15:37 ` [PATCH v11 crypto 07/12] crypto: chtls - Program the TLS session Key Atul Gupta
2018-03-16 15:37 ` [PATCH v11 crypto 08/12] crypto : chtls - CPL handler definition Atul Gupta
2018-03-16 15:37 ` [PATCH v11 crypto 09/12] crypto: chtls - Inline TLS record Tx Atul Gupta
2018-03-16 15:37 ` [PATCH v11 crypto 10/12] crypto: chtls - Inline TLS record Rx Atul Gupta
2018-03-16 15:37 ` [PATCH v11 crypto 11/12] crypto: chtls - Register chtls with net tls Atul Gupta
2018-03-16 15:37 ` [PATCH v11 crypto 12/12] crypto: chtls - Makefile Kconfig Atul Gupta
-- strict thread matches above, loose matches on Subject: below --
2018-03-16 15:36 [PATCH v11 crypto 00/12] Chelsio Inline TLS Atul Gupta
2018-03-18 0:02 ` David Miller
2018-03-18 14:30 ` Atul Gupta
2018-03-18 14:36 ` David Miller
2018-03-19 3:26 ` Atul Gupta
2018-03-19 9:22 ` Herbert Xu
2018-03-19 9:44 ` Atul Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180318225337.GA19891@bistromath.localdomain \
--to=sd@queasysnail.net \
--cc=atul.gupta@chelsio.com \
--cc=davejwatson@fb.com \
--cc=davem@davemloft.net \
--cc=ganeshgr@chelsio.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).