From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:49076 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1754523AbeCRWxo (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sun, 18 Mar 2018 18:53:44 -0400
Date: Sun, 18 Mar 2018 23:53:37 +0100
From: Sabrina Dubroca <sd@queasysnail.net>
To: Atul Gupta <atul.gupta@chelsio.com>
Cc: davejwatson@fb.com, davem@davemloft.net,
        herbert@gondor.apana.org.au, sbrivio@redhat.com,
        linux-crypto@vger.kernel.org, netdev@vger.kernel.org,
        ganeshgr@chelsio.com
Subject: Re: [PATCH v11 crypto 06/12] crypto: chtls - structure and macro for
 Inline TLS
Message-ID: <20180318225337.GA19891@bistromath.localdomain>
References: <1521214582-28838-1-git-send-email-atul.gupta@chelsio.com>
 <1521214661-28928-6-git-send-email-atul.gupta@chelsio.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1521214661-28928-6-git-send-email-atul.gupta@chelsio.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

2018-03-16, 21:07:35 +0530, Atul Gupta wrote:
[...]
> +#define SOCK_INLINE (31)
[...]

> +static inline int csk_flag(const struct sock *sk, enum csk_flags flag)
> +{
> +	struct chtls_sock *csk = rcu_dereference_sk_user_data(sk);
> +
> +	if (!sock_flag(sk, SOCK_INLINE))
> +		return 0;
> +	return test_bit(flag, &csk->flags);
> +}

Should drivers really start defining their own socket flags?


> +static inline void set_queue(struct sk_buff *skb,
> +			     unsigned int queue, const struct sock *sk)
> +{
> +	skb->queue_mapping = queue;
> +}

That's skb_set_queue_mapping(), no need to define your own.

-- 
Sabrina