From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:56550 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1754531AbeCRWhN (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sun, 18 Mar 2018 18:37:13 -0400
Date: Sun, 18 Mar 2018 23:37:05 +0100
From: Stefano Brivio <sbrivio@redhat.com>
To: Raju Rangoju <rajur@chelsio.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, nirranjan@chelsio.com,
        indranil@chelsio.com, venkatesh@chelsio.com,
        swise@opengridcomputing.com, bharat@chelsio.com,
        Ganesh Goudar <ganeshgr@chelsio.com>
Subject: Re: [PATCH net-next 2/5] cxgb4: Add support to initialise/read SRQ
 entries
Message-ID: <20180318233705.2072e6b4@epycfail>
In-Reply-To: <20180317072229.21211-3-rajur@chelsio.com>
References: <20180317072229.21211-1-rajur@chelsio.com>
        <20180317072229.21211-3-rajur@chelsio.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Sat, 17 Mar 2018 12:52:26 +0530
Raju Rangoju <rajur@chelsio.com> wrote:

> +struct srq_data *t4_init_srq(int srq_size)
> +{
> +	struct srq_data *s;
> +
> +	s = kzalloc(sizeof(*s), GFP_KERNEL | __GFP_NOWARN);
> +	if (!s)
> +		s = vzalloc(sizeof(*s));
> +	if (!s)
> +		return NULL;

I guess you could use kvzalloc() here.

> [...]
>
> +++ b/drivers/net/ethernet/chelsio/cxgb4/srq.h
>
> [...]
>
> +enum {
> +	SRQ_WAIT_TO = (HZ * 5),
> +};

Why not #define? Am I missing something?

-- 
Stefano