From: Stephen Hemminger <stephen@networkplumber.org>
To: Roman Mashak <mrv@mojatatu.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH iproute2 1/1] tc: fix conversion types when printing actions unsigned values
Date: Mon, 19 Mar 2018 10:55:26 -0700 [thread overview]
Message-ID: <20180319105526.67094dcd@xeon-e3> (raw)
In-Reply-To: <1521481807-20401-1-git-send-email-mrv@mojatatu.com>
On Mon, 19 Mar 2018 13:50:07 -0400
Roman Mashak <mrv@mojatatu.com> wrote:
> Signed-off-by: Roman Mashak <mrv@mojatatu.com>
> ---
> tc/m_action.c | 2 +-
> tc/m_gact.c | 2 +-
> tc/m_ife.c | 2 +-
> tc/m_pedit.c | 2 +-
> tc/m_sample.c | 6 +++---
> tc/m_tunnel_key.c | 2 +-
> 6 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/tc/m_action.c b/tc/m_action.c
> index 148f1372d414..85c9d44c7e50 100644
> --- a/tc/m_action.c
> +++ b/tc/m_action.c
> @@ -408,7 +408,7 @@ int print_action(const struct sockaddr_nl *who,
> if (tb[TCA_ROOT_COUNT])
> tot_acts = RTA_DATA(tb[TCA_ROOT_COUNT]);
>
> - fprintf(fp, "total acts %d\n", tot_acts ? *tot_acts:0);
> + fprintf(fp, "total acts %u\n", tot_acts ? *tot_acts:0);
Please add spaces around : in trigraph.
When fixing code, it has to pass style checkers.
next prev parent reply other threads:[~2018-03-19 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 17:50 [PATCH iproute2 1/1] tc: fix conversion types when printing actions unsigned values Roman Mashak
2018-03-19 17:55 ` Stephen Hemminger [this message]
2018-03-19 18:14 ` Roman Mashak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319105526.67094dcd@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).