Netdev List
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Kevin Hao <haokexin@gmail.com>
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH] net: phy: realtek: Add dummy stubs for MMD register access for rtl8211b
Date: Mon, 19 Mar 2018 13:39:39 +0100	[thread overview]
Message-ID: <20180319123939.GC19795@lunn.ch> (raw)
In-Reply-To: <20180319120547.18707-1-haokexin@gmail.com>

On Mon, Mar 19, 2018 at 08:05:47PM +0800, Kevin Hao wrote:
> The Ethernet on mpc8315erdb is broken since commit b6b5e8a69118
> ("gianfar: Disable EEE autoneg by default"). The reason is that
> even though the rtl8211b doesn't support the MMD extended registers
> access, it does return some random values if we trying to access
> the MMD register via indirect method. This makes it seem that the
> EEE is supported by this phy device. And the subsequent writing to
> the MMD registers does cause the phy malfunction. So add dummy stubs
> for the MMD register access to fix this issue.

Hi Kevin

The Micrel PHY has the same problem. Please add generic
genphy_read_mmd_unsupported() and genphy_write_mmd_unsupported() to
phy_device.c, and use them from both the Micrel and Realtek PHY
drivers.

Also, a return value of -EOPNOTSUPP is more appropriate.

Thanks

	Andrew

  reply	other threads:[~2018-03-19 12:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-19 12:05 [PATCH] net: phy: realtek: Add dummy stubs for MMD register access for rtl8211b Kevin Hao
2018-03-19 12:39 ` Andrew Lunn [this message]
2018-03-19 12:51   ` Kevin Hao
2018-03-19 14:31   ` Claudiu Manoil
2018-03-19 15:37     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180319123939.GC19795@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=claudiu.manoil@nxp.com \
    --cc=f.fainelli@gmail.com \
    --cc=haokexin@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox