From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f67.google.com ([74.125.83.67]:35690 "EHLO
        mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754892AbeCSMv3 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 19 Mar 2018 08:51:29 -0400
Received: by mail-pg0-f67.google.com with SMTP id d1so6854039pgv.2
        for <netdev@vger.kernel.org>; Mon, 19 Mar 2018 05:51:29 -0700 (PDT)
Date: Mon, 19 Mar 2018 20:51:13 +0800
From: Kevin Hao <haokexin@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH] net: phy: realtek: Add dummy stubs for MMD register
 access for rtl8211b
Message-ID: <20180319125113.GA17024@pek-khao-d2>
References: <20180319120547.18707-1-haokexin@gmail.com>
 <20180319123939.GC19795@lunn.ch>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="yrj/dFKFPuw6o+aM"
Content-Disposition: inline
In-Reply-To: <20180319123939.GC19795@lunn.ch>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


--yrj/dFKFPuw6o+aM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 19, 2018 at 01:39:39PM +0100, Andrew Lunn wrote:
> On Mon, Mar 19, 2018 at 08:05:47PM +0800, Kevin Hao wrote:
> > The Ethernet on mpc8315erdb is broken since commit b6b5e8a69118
> > ("gianfar: Disable EEE autoneg by default"). The reason is that
> > even though the rtl8211b doesn't support the MMD extended registers
> > access, it does return some random values if we trying to access
> > the MMD register via indirect method. This makes it seem that the
> > EEE is supported by this phy device. And the subsequent writing to
> > the MMD registers does cause the phy malfunction. So add dummy stubs
> > for the MMD register access to fix this issue.
>=20
> Hi Kevin
>=20
> The Micrel PHY has the same problem. Please add generic
> genphy_read_mmd_unsupported() and genphy_write_mmd_unsupported() to
> phy_device.c, and use them from both the Micrel and Realtek PHY
> drivers.
>=20
> Also, a return value of -EOPNOTSUPP is more appropriate.

Thanks for the suggestion. Will do.

Thanks,
Kevin

>=20
> Thanks
>=20
> 	Andrew

--yrj/dFKFPuw6o+aM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEHc6qFoLCZqgJD98Zk1jtMN6usXEFAlqvsjoACgkQk1jtMN6u
sXHaPAf9FmGkNlXAeqK5Ywnkt1U4jxKjoU7xPOc4xiLOgaOjW5Wxw0wTzRZTFsJd
ctb6KfgYs6rnasGLCUYv2BKSAVhabrlD7ybA0IKrrxoPRnzv8u97+dRERt9L6+T1
N+SGawmX3JO9paZXMDzjG6nJDwzPN2Wh0J7BmIHkqKhQJitLqaBlP731BAG15nNi
ZLrxc2T0ov6iNL/pCECgeCEjH6JOeeZE8qSmejfjoPoFAw30/+V0tP6R8+6VmH3M
wbTXN1O7INr4wgcph/KmmJ3wAspm6acn9gBPYcazt48MLOqT0xIdXmmz0qxqrAVC
kcGPLxZ+Y/gGteL1tsak94upk5vFJw==
=BCAR
-----END PGP SIGNATURE-----

--yrj/dFKFPuw6o+aM--