netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Antoine Tenart <antoine.tenart@bootlin.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	davem@davemloft.net, kishon@ti.com, gregory.clement@bootlin.com,
	jason@lakedaemon.net, sebastian.hesselbarth@gmail.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	thomas.petazzoni@bootlin.com, maxime.chevallier@bootlin.com,
	miquel.raynal@bootlin.com, nadavh@marvell.com,
	stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next 02/10] net: phy: phylink: allow 10GKR interface to use in-band negotiation
Date: Mon, 19 Mar 2018 13:18:05 +0000	[thread overview]
Message-ID: <20180319131804.GD2743@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20180319131009.GJ4519@kwain>

On Mon, Mar 19, 2018 at 02:10:09PM +0100, Antoine Tenart wrote:
> Hi Andrew,
> 
> On Mon, Mar 19, 2018 at 01:59:53PM +0100, Andrew Lunn wrote:
> > 
> > If they don't have PHYs, how are the connected to the outside world?
> 
> On 7k/8k you have the following scheme for 10G only interfaces:
> 
>    MAC -- Comphy -- PHY -- SFP cage -- ...
> 
> Or
> 
>    MAC -- Comphy -- SFP cage -- ...
> 
> The comphy provides serdes lanes, and can be configured in various
> modes (SGMII, 2500SGMII, 10GKR...).

Right - the correct mode is dependent on the SFP module plugged into
the cage.  Trying to describe this by ignoring the SFP cage isn't
going to work out well for end-user functionality, though is fine if
you're just hacking a configuration to test (which would not be
suitable for mainline kernels!)

As I've recently replied to Yan, this is a configuration I haven't
tested yet, and it's entirely possible that phylink may need some
tweaks for it.

What you have is a very similar setup to what is on Clearfog with
its SFP cage, where the SFP cage is connected directly to the
Armada 388.  That only has to deal with 2500base-X / 1000base-X /
SGMII and not 10G.

What I want is to avoid hacks as much as possible here - if there is
a short-coming with SFP/phylink here, we need to address that
properly.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

  reply	other threads:[~2018-03-19 13:18 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-16 10:33 [PATCH net-next 00/10] net: mvpp2: phylink conversion Antoine Tenart
2018-03-16 10:33 ` [PATCH net-next 01/10] net: mvpp2: align the ethtool ops definition Antoine Tenart
2018-03-16 10:33 ` [PATCH net-next 02/10] net: phy: phylink: allow 10GKR interface to use in-band negotiation Antoine Tenart
2018-03-16 15:53   ` Russell King - ARM Linux
2018-03-19  8:52     ` Antoine Tenart
2018-03-19 11:12       ` Russell King - ARM Linux
2018-03-19 12:52         ` Antoine Tenart
2018-03-19 12:59           ` Andrew Lunn
2018-03-19 13:03             ` [EXT] " Stefan Chulski
2018-03-19 13:08               ` Andrew Lunn
2018-03-19 13:13                 ` Antoine Tenart
2018-03-19 13:24                   ` Andrew Lunn
2018-03-19 13:19                 ` Stefan Chulski
2018-03-19 13:23                   ` Andrew Lunn
2018-03-19 13:42                   ` Russell King - ARM Linux
2018-03-19 13:10             ` Antoine Tenart
2018-03-19 13:18               ` Russell King - ARM Linux [this message]
2018-03-19 13:26                 ` Antoine Tenart
2018-03-19 12:58         ` [EXT] " Stefan Chulski
2018-03-19 13:01           ` Yan Markman
2018-03-19 13:05             ` Russell King - ARM Linux
2018-03-16 10:33 ` [PATCH net-next 03/10] net: mvpp2: phylink support Antoine Tenart
2018-03-16 16:03   ` Russell King - ARM Linux
2018-03-19  8:45     ` Antoine Tenart
2018-03-16 10:33 ` [PATCH net-next 04/10] phy: add 2.5G SGMII mode to the phy_mode enum Antoine Tenart
2018-03-19  9:46   ` Kishon Vijay Abraham I
2018-03-16 10:33 ` [PATCH net-next 05/10] phy: cp110-comphy: 2.5G SGMII mode Antoine Tenart
2018-03-18  4:42   ` Baruch Siach
2018-03-19  8:44     ` Antoine Tenart
2018-03-16 10:33 ` [PATCH net-next 06/10] net: mvpp2: 1000baseX support Antoine Tenart
2018-03-16 10:33 ` [PATCH net-next 07/10] net: mvpp2: 2500baseX support Antoine Tenart
2018-03-16 10:33 ` [PATCH net-next 08/10] arm64: dts: marvell: 7040-db: set the 10G interface management to in-band Antoine Tenart
2018-03-16 10:33 ` [PATCH net-next 09/10] arm64: dts: marvell: 8040-db: set the 10G interfaces " Antoine Tenart
2018-03-16 10:33 ` [PATCH net-next 10/10] arm64: dts: marvell: mcbin: enable the fourth network interface Antoine Tenart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180319131804.GD2743@n2100.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=andrew@lunn.ch \
    --cc=antoine.tenart@bootlin.com \
    --cc=davem@davemloft.net \
    --cc=gregory.clement@bootlin.com \
    --cc=jason@lakedaemon.net \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=stefanc@marvell.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=ymarkman@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).