From: Stefano Brivio <sbrivio@redhat.com>
To: Atul Gupta <atul.gupta@chelsio.com>
Cc: davem@davemloft.net, herbert@gondor.apana.org.au,
davejwatson@fb.com, sd@queasysnail.net,
linux-crypto@vger.kernel.org, netdev@vger.kernel.org,
ganeshgr@chelsio.com, Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH v12 net-next 01/12] tls: support for Inline tls record
Date: Mon, 19 Mar 2018 17:57:44 +0100 [thread overview]
Message-ID: <20180319175744.6c4523ea@epycfail> (raw)
In-Reply-To: <1521467745-23201-2-git-send-email-atul.gupta@chelsio.com>
On Mon, 19 Mar 2018 19:25:34 +0530
Atul Gupta <atul.gupta@chelsio.com> wrote:
> @@ -268,6 +259,8 @@ static void tls_sk_proto_close(struct sock *sk, long timeout)
> skip_tx_cleanup:
> release_sock(sk);
> sk_proto_close(sk, timeout);
> + if (ctx && ctx->tx_conf == TLS_HW_RECORD)
> + kfree(ctx);
Why are you still dereferencing ctx after it has been freed, as
reported by Julia (<alpine.DEB.2.20.1803181700230.2420@hadrien>) on v11?
--
Stefano
next prev parent reply other threads:[~2018-03-19 16:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 13:55 [PATCH v12 net-next 00/12] Chelsio Inline TLS Atul Gupta
2018-03-19 13:55 ` [PATCH v12 net-next 01/12] tls: support for Inline tls record Atul Gupta
2018-03-19 16:57 ` Stefano Brivio [this message]
2018-03-20 17:53 ` kbuild test robot
2018-03-20 17:53 ` [RFC PATCH] tls: create_ctx() can be static kbuild test robot
2018-03-19 13:55 ` [PATCH v12 net-next 02/12] ethtool: enable Inline TLS in HW Atul Gupta
2018-03-19 13:55 ` [PATCH v12 net-next 03/12] cxgb4: Inline TLS FW Interface Atul Gupta
2018-03-19 13:55 ` [PATCH v12 net-next 04/12] cxgb4: LLD driver changes to support TLS Atul Gupta
2018-03-19 13:55 ` [PATCH v12 net-next 05/12] crypto: chcr - Inline TLS Key Macros Atul Gupta
2018-03-19 13:55 ` [PATCH v12 net-next 06/12] crypto: chtls - structure and macro for Inline TLS Atul Gupta
2018-03-19 17:02 ` Stefano Brivio
2018-03-19 13:55 ` [PATCH v12 net-next 07/12] crypto: chtls - Program the TLS session Key Atul Gupta
2018-03-19 13:55 ` [PATCH v12 net-next 08/12] crypto : chtls - CPL handler definition Atul Gupta
2018-03-19 13:55 ` [PATCH v12 net-next 09/12] crypto: chtls - Inline TLS record Tx Atul Gupta
2018-03-19 16:57 ` Stefano Brivio
2018-03-19 13:55 ` [PATCH v12 net-next 10/12] crypto: chtls - Inline TLS record Rx Atul Gupta
2018-03-19 17:01 ` Stefano Brivio
2018-03-19 13:55 ` [PATCH v12 net-next 11/12] crypto: chtls - Register chtls with net tls Atul Gupta
2018-03-19 13:55 ` [PATCH v12 net-next 12/12] crypto: chtls - Makefile Kconfig Atul Gupta
2018-03-20 16:28 ` kbuild test robot
2018-03-20 18:06 ` kbuild test robot
2018-03-19 16:57 ` [PATCH v12 net-next 00/12] Chelsio Inline TLS Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319175744.6c4523ea@epycfail \
--to=sbrivio@redhat.com \
--cc=atul.gupta@chelsio.com \
--cc=davejwatson@fb.com \
--cc=davem@davemloft.net \
--cc=ganeshgr@chelsio.com \
--cc=herbert@gondor.apana.org.au \
--cc=julia.lawall@lip6.fr \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).