From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:52014 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966537AbeCSQ5v (ORCPT ); Mon, 19 Mar 2018 12:57:51 -0400 Date: Mon, 19 Mar 2018 17:57:44 +0100 From: Stefano Brivio To: Atul Gupta Cc: davem@davemloft.net, herbert@gondor.apana.org.au, davejwatson@fb.com, sd@queasysnail.net, linux-crypto@vger.kernel.org, netdev@vger.kernel.org, ganeshgr@chelsio.com, Julia Lawall Subject: Re: [PATCH v12 net-next 01/12] tls: support for Inline tls record Message-ID: <20180319175744.6c4523ea@epycfail> In-Reply-To: <1521467745-23201-2-git-send-email-atul.gupta@chelsio.com> References: <1521467745-23201-1-git-send-email-atul.gupta@chelsio.com> <1521467745-23201-2-git-send-email-atul.gupta@chelsio.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 19 Mar 2018 19:25:34 +0530 Atul Gupta wrote: > @@ -268,6 +259,8 @@ static void tls_sk_proto_close(struct sock *sk, long timeout) > skip_tx_cleanup: > release_sock(sk); > sk_proto_close(sk, timeout); > + if (ctx && ctx->tx_conf == TLS_HW_RECORD) > + kfree(ctx); Why are you still dereferencing ctx after it has been freed, as reported by Julia () on v11? -- Stefano