From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:55426 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S967619AbeCSRCz (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 19 Mar 2018 13:02:55 -0400
Date: Mon, 19 Mar 2018 18:02:49 +0100
From: Stefano Brivio <sbrivio@redhat.com>
To: Atul Gupta <atul.gupta@chelsio.com>
Cc: davem@davemloft.net, herbert@gondor.apana.org.au,
        davejwatson@fb.com, sd@queasysnail.net,
        linux-crypto@vger.kernel.org, netdev@vger.kernel.org,
        ganeshgr@chelsio.com
Subject: Re: [PATCH v12 net-next 06/12] crypto: chtls - structure and macro
 for Inline TLS
Message-ID: <20180319180249.4f903662@epycfail>
In-Reply-To: <1521467745-23201-7-git-send-email-atul.gupta@chelsio.com>
References: <1521467745-23201-1-git-send-email-atul.gupta@chelsio.com>
        <1521467745-23201-7-git-send-email-atul.gupta@chelsio.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, 19 Mar 2018 19:25:39 +0530
Atul Gupta <atul.gupta@chelsio.com> wrote:

> +#define SOCK_INLINE (31)
>
> [...]
>
> +static inline int csk_flag(const struct sock *sk, enum csk_flags flag)
> +{
> +	struct chtls_sock *csk = rcu_dereference_sk_user_data(sk);
> +
> +	if (!sock_flag(sk, SOCK_INLINE))
> +		return 0;

Please take care of the comments.

I understand this series is big and you might be tempted to minimize
your effort in the hope that reviewers will fail to check that you
addressed their concerns.

You are also succeeding in making it hard by re-posting so quickly,
addressing a few "easy" comments at a time, without taking care of the
change log.

But still I believe your hopes are not so reasonably founded.

-- 
Stefano