netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Add possibility to turn off promiscuous mode
@ 2018-03-20 10:28 Stephan Mondwurf
  2018-03-20 14:36 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Stephan Mondwurf @ 2018-03-20 10:28 UTC (permalink / raw)
  To: Vince Bridgers; +Cc: netdev, nios2-dev

The driver is capable of switching on the promiscuous mode.

This patch adds the possibility to turn it off again.

Signed-off-by: Stephan Mondwurf <s.mondwurf@astro-kom.de>
---
  drivers/net/ethernet/altera/altera_tse_main.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/altera/altera_tse_main.c 
b/drivers/net/ethernet/altera/altera_tse_main.c
index 527908c..241d27b 100644
--- a/drivers/net/ethernet/altera/altera_tse_main.c
+++ b/drivers/net/ethernet/altera/altera_tse_main.c
@@ -1067,6 +1067,9 @@ static void tse_set_rx_mode_hashfilter(struct 
net_device *dev)
  	if (dev->flags & IFF_PROMISC)
  		tse_set_bit(priv->mac_dev, tse_csroffs(command_config),
  			    MAC_CMDCFG_PROMIS_EN);
+	else
+		tse_clear_bit(priv->mac_dev, tse_csroffs(command_config),
+			      MAC_CMDCFG_PROMIS_EN);

  	if (dev->flags & IFF_ALLMULTI)
  		altera_tse_set_mcfilterall(dev);
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Add possibility to turn off promiscuous mode
  2018-03-20 10:28 [PATCH] Add possibility to turn off promiscuous mode Stephan Mondwurf
@ 2018-03-20 14:36 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-03-20 14:36 UTC (permalink / raw)
  To: s.mondwurf; +Cc: vbridger, netdev, nios2-dev

From: Stephan Mondwurf <s.mondwurf@astro-kom.de>
Date: Tue, 20 Mar 2018 11:28:20 +0100

> The driver is capable of switching on the promiscuous mode.
> 
> This patch adds the possibility to turn it off again.
> 
> Signed-off-by: Stephan Mondwurf <s.mondwurf@astro-kom.de>

Please fix your patch submissions.

Your subject line should have an appropriate subsystem prefix, for
drivers like this simply "altera: " is sufficient.  You should
also specify what tree your patch is targetting in the '[PATCH]'
string.  So together that means:

	Subject: [PATCH net] altera: Add possibility to turn off promiscuous mode

or:

	Subject: [PATCH net-next] altera: Add possibility to turn off promiscuous mode

Also, your patches has both been completely corrupted by your email
client.  Long lines have been split up.

Please email the patch to yourself, and try to apply it.  Do not
resubmit the patch to the list here until you can do that
successfully.

Thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-03-20 14:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-20 10:28 [PATCH] Add possibility to turn off promiscuous mode Stephan Mondwurf
2018-03-20 14:36 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).