From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: dev_forward_skb(): Scrub packet's per-netns info only when crossing netns Date: Tue, 20 Mar 2018 12:34:01 -0400 (EDT) Message-ID: <20180320.123401.2138083793709750726.davem@davemloft.net> References: <5AB12A0E.2060704@ORACLE.COM> <20180320.120036.1999626754164343704.davem@davemloft.net> <5AB132C5.5010806@ORACLE.COM> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, idan.brown@ORACLE.COM, yuval.shaia@ORACLE.COM To: LIRAN.ALON@ORACLE.COM Return-path: In-Reply-To: <5AB132C5.5010806@ORACLE.COM> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Liran Alon Date: Tue, 20 Mar 2018 18:11:49 +0200 > 1. Do we want to make a flag for every bug that is user-space visible? > I think there is place for consideration on a per-case basis. I still > don't see how a user can utilize this behaviour. He is basically > loosing information (skb->mark) without this patch. And maybe people trying to work in this situation have added code to get the mark set some other way, or to validate that it is in fact zero after passing through, which we would break with this change. If it's set to zero now, it's reasonable to expect it to be zero. By changing it to non-zero, different rules and routes will match and this for sure has potential to break things.