From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from aserp2130.oracle.com ([141.146.126.79]:53766 "EHLO
        aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753340AbeCTN3m (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 20 Mar 2018 09:29:42 -0400
Date: Tue, 20 Mar 2018 09:29:27 -0400
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: H??kon Bugge <haakon.bugge@oracle.com>
Cc: Kirill Tkhai <ktkhai@virtuozzo.com>, rds-devel@oss.oracle.com,
        OFED mailing list <linux-rdma@vger.kernel.org>,
        netdev@vger.kernel.org, edumazet@google.com, davem@davemloft.net
Subject: Re: [rds-devel] [PATCH RFC RFC] rds: Use NETDEV_UNREGISTER in
 rds_tcp_dev_event() (then kill NETDEV_UNREGISTER_FINAL)
Message-ID: <20180320132927.GA4079@oracle.com>
References: <152120385651.2065.2567466917573907029.stgit@localhost.localdomain>
 <20180316130008.GE16870@oracle.com>
 <512c2483-aa62-b385-6079-1b6ff8ba4636@virtuozzo.com>
 <20180316172918.GM16870@oracle.com>
 <82d6e954-8043-078c-266c-2f1ac992f864@virtuozzo.com>
 <20180317141507.GC873@oracle.com>
 <20180317212553.GA16416@oracle.com>
 <6b8e60bf-9ea2-ed1c-19ad-809a805f64a3@virtuozzo.com>
 <20180318204520.GA14963@oracle.com>
 <CBB6A644-8650-41F5-800B-A34DEFBB2C4C@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CBB6A644-8650-41F5-800B-A34DEFBB2C4C@oracle.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On (03/20/18 12:37), H??kon Bugge wrote:
> 
> A little nit below. And some spelling issues in existing commentary
> you can consider fixing, since you reshuffle this file considerable.
> > +	if (net != &init_net && rtn->ctl_table)
> > +		kfree(rtn->ctl_table);
> 
> Well, this comes from the existing code, but as pointed out by Linus
> recently, kfree() handles NULL pointers. So, if rtn->ctl_table is
> NULL most likely, the code is OK _if_ you add an unlikely() around the
> if-clause. Otherwise, the ??? && rtn->ctl_table??? can simply be removed.

As you observe correctly, this comes from the existing code,
and is unrelated to the contents of the commit comment.

So if we feel passionately about htis, let us please fix this
separately, with its own ceremony.


> s/when/When/
> s/parameters,this/parameters, this/
> 
> Well, not part of your commit.

As above.
> 
> 
> >  * function  resets the RDS connections in that netns  so that we can
> 
> Two double spaces incidents above
> 
> Not part of your commit

As above.

Thanks much.
--Sowmini