From: Matthew Wilcox <willy@infradead.org>
To: David Miller <davem@davemloft.net>
Cc: maorg@mellanox.com, saeedm@mellanox.com, matanb@mellanox.com,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
leon@kernel.org
Subject: Re: [PATCH] mlx5: Remove call to ida_pre_get
Date: Tue, 20 Mar 2018 08:20:04 -0700 [thread overview]
Message-ID: <20180320152004.GA12959@bombadil.infradead.org> (raw)
In-Reply-To: <20180320.104620.1702410080256879438.davem@davemloft.net>
On Tue, Mar 20, 2018 at 10:46:20AM -0400, David Miller wrote:
> From: Maor Gottlieb <maorg@mellanox.com>
> Date: Tue, 20 Mar 2018 14:41:49 +0200
>
> > Saeed, Matan and I okay with this fix as well, it looks like it
> > shouldn't impact on the insertion rate.
>
> I've applied this to net-next, thanks everyone.
Thanks, Dave.
I realised why this made sense when it was originally written. Before
December 2016 (commit 7ad3d4d85c7a), ida_pre_get used to allocate one
bitmap per ida. I moved it to a percpu variable, and at that point this
stopped making sense.
prev parent reply other threads:[~2018-03-20 15:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 2:57 [PATCH] mlx5: Remove call to ida_pre_get Matthew Wilcox
2018-03-15 23:58 ` Saeed Mahameed
2018-03-16 1:30 ` Matthew Wilcox
2018-03-20 3:29 ` Saeed Mahameed
2018-03-20 12:41 ` Maor Gottlieb
2018-03-20 14:46 ` David Miller
2018-03-20 15:20 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320152004.GA12959@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=davem@davemloft.net \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@mellanox.com \
--cc=matanb@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).