From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([198.137.202.133]:45318 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751186AbeCTPUI (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 20 Mar 2018 11:20:08 -0400
Date: Tue, 20 Mar 2018 08:20:04 -0700
From: Matthew Wilcox <willy@infradead.org>
To: David Miller <davem@davemloft.net>
Cc: maorg@mellanox.com, saeedm@mellanox.com, matanb@mellanox.com,
        netdev@vger.kernel.org, linux-rdma@vger.kernel.org, leon@kernel.org
Subject: Re: [PATCH] mlx5: Remove call to ida_pre_get
Message-ID: <20180320152004.GA12959@bombadil.infradead.org>
References: <20180316013007.GA1875@bombadil.infradead.org>
 <1521516573.32324.63.camel@mellanox.com>
 <5d362a5b-9697-e1c1-c48c-3d64564f09e7@mellanox.com>
 <20180320.104620.1702410080256879438.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180320.104620.1702410080256879438.davem@davemloft.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, Mar 20, 2018 at 10:46:20AM -0400, David Miller wrote:
> From: Maor Gottlieb <maorg@mellanox.com>
> Date: Tue, 20 Mar 2018 14:41:49 +0200
> 
> > Saeed, Matan and I okay with this fix as well, it looks like it
> > shouldn't impact on the insertion rate.
> 
> I've applied this to net-next, thanks everyone.

Thanks, Dave.

I realised why this made sense when it was originally written.  Before
December 2016 (commit 7ad3d4d85c7a), ida_pre_get used to allocate one
bitmap per ida.  I moved it to a percpu variable, and at that point this
stopped making sense.