From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wtarreau.pck.nerim.net ([62.212.114.60]:41739 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbeCTQNj (ORCPT ); Tue, 20 Mar 2018 12:13:39 -0400 Date: Tue, 20 Mar 2018 17:13:31 +0100 From: Willy Tarreau To: davem@davemloft.net Cc: yongjian xu , Soheil Hassas Yeganeh , netdev@vger.kernel.org, ycheng@google.com, ncardwell@google.com, nefelim4ag@gmail.com, Soheil Hassas Yeganeh , Eric Dumazet Subject: Re: [PATCH linux-stable-4.14] tcp: reset sk_send_head in tcp_write_queue_purge Message-ID: <20180320161331.GA31452@1wt.eu> References: <20180315160913.180918-1-soheil.kdev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Hi David, regarding the patch below, I'm not certain whether you planned to take it since it's marked "not applicable" on patchwork, but I suspect it's only because it doesn't apply to mainline. However, please note that there are two typos in commit IDs referenced in the commit message that might be nice to fix before merging : > > For example, after 27fid7a8ed38 (tcp: purge write queue upon RST), - here it's "a27fd7a8ed38" (missing 'a' and extra 'i' in the middle) - and lower in the fixes tag there's the extra 'i' as well : > > Fixes: a27fid7a8ed38 (tcp: purge write queue upon RST) There was another report today on the stable list for a similar crash on 4.14.28 and I suspect it's the one I saw this week-end on my firewall after upgrading from 4.14.10 to 4.14.27 though I didn't have the symbols to confirm. Thanks, Willy