From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f68.google.com ([209.85.160.68]:45458 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751269AbeCTU3O (ORCPT ); Tue, 20 Mar 2018 16:29:14 -0400 Received: by mail-pl0-f68.google.com with SMTP id n15-v6so1715211plp.12 for ; Tue, 20 Mar 2018 13:29:14 -0700 (PDT) From: Stephen Hemminger To: netdev@vger.kernel.org Cc: Stephen Hemminger Subject: [PATCH iproute2 v2 1/9] bridge: avoid snprint truncation on time Date: Tue, 20 Mar 2018 13:29:01 -0700 Message-Id: <20180320202909.22166-2-stephen@networkplumber.org> In-Reply-To: <20180320202909.22166-1-stephen@networkplumber.org> References: <20180320202909.22166-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org List-ID: This fixes new gcc warning about possible string overflow. mdb.c: In function ‘__print_router_port_stats’: mdb.c:61:11: warning: ‘%.2i’ directive output may be truncated writing between 2 and 7 bytes into a region of size between 0 and 4 [-Wformat-truncation=] "%4i.%.2i", (int)tv.tv_sec, ^~~~ Note: already fixed in iproute2-next. Signed-off-by: Stephen Hemminger --- bridge/mdb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bridge/mdb.c b/bridge/mdb.c index 58c20b82b8a6..659cac3ff20a 100644 --- a/bridge/mdb.c +++ b/bridge/mdb.c @@ -55,7 +55,7 @@ static void __print_router_port_stats(FILE *f, struct rtattr *pattr) __jiffies_to_tv(&tv, rta_getattr_u32(tb[MDBA_ROUTER_PATTR_TIMER])); if (jw_global) { - char formatted_time[9]; + char formatted_time[32]; snprintf(formatted_time, sizeof(formatted_time), "%4i.%.2i", (int)tv.tv_sec, @@ -184,7 +184,7 @@ static void print_mdb_entry(FILE *f, int ifindex, struct br_mdb_entry *e, __jiffies_to_tv(&tv, rta_getattr_u32(tb[MDBA_MDB_EATTR_TIMER])); if (jw_global) { - char formatted_time[9]; + char formatted_time[32]; snprintf(formatted_time, sizeof(formatted_time), "%4i.%.2i", (int)tv.tv_sec, -- 2.16.2