From: David Miller <davem@davemloft.net>
To: rao.shoaib@oracle.com
Cc: borisp@mellanox.com, saeedm@mellanox.com, netdev@vger.kernel.org,
davejwatson@fb.com, ilyal@mellanox.com, aviadye@mellanox.com
Subject: Re: [PATCH net-next 01/14] tcp: Add clean acked data hook
Date: Wed, 21 Mar 2018 12:32:07 -0400 (EDT) [thread overview]
Message-ID: <20180321.123207.1873098520164488354.davem@davemloft.net> (raw)
In-Reply-To: <34fcec92-dfc8-644d-ed54-c54eab71ffb6@oracle.com>
From: Rao Shoaib <rao.shoaib@oracle.com>
Date: Wed, 21 Mar 2018 09:16:48 -0700
> I agree, in fact I was using function pointers for the exact reason,
> to change the functionality of a function. I asked Dave about the
> use and he said No (Also note that the relevant CPU optimizations
> have been turned off on selected NIC's due to the latest security
> issues -- On AMD CPU's the optimizations are not turned off). So it
> is Dave's decision -- I am hoping that he would reconsider and allow
> me to use pointers as well as pointers solve the problem nicely and
> are used extensively.
This situation is different from your's Rao.
That proposal was to add indirect calls for things the TCP stack
internally can make internal state checks for.
Whereas this current patch discussed here is a driver offload hook,
which TCP cannot internally possibly know anything about.
I am fine with what Boris et al. are doing here. It is a different
situation than your's.
next prev parent reply other threads:[~2018-03-21 16:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 2:44 [PATCH net-next 00/14] TLS offload, netdev & MLX5 support Saeed Mahameed
2018-03-20 2:44 ` [PATCH net-next 01/14] tcp: Add clean acked data hook Saeed Mahameed
2018-03-20 20:36 ` Rao Shoaib
2018-03-21 11:21 ` Boris Pismenny
2018-03-21 16:16 ` Rao Shoaib
2018-03-21 16:32 ` David Miller [this message]
2018-03-20 2:44 ` [PATCH net-next 02/14] net: Rename and export copy_skb_header Saeed Mahameed
2018-03-20 2:44 ` [PATCH net-next 03/14] net: Add Software fallback infrastructure for socket dependent offloads Saeed Mahameed
2018-03-20 2:45 ` [PATCH net-next 04/14] net: Add TLS offload netdev ops Saeed Mahameed
2018-03-20 2:45 ` [PATCH net-next 05/14] net: Add TLS TX offload features Saeed Mahameed
2018-03-20 2:45 ` [PATCH net-next 06/14] net/tls: Add generic NIC offload infrastructure Saeed Mahameed
2018-03-21 11:15 ` Kirill Tkhai
2018-03-21 15:53 ` Boris Pismenny
2018-03-21 16:31 ` Kirill Tkhai
2018-03-21 20:50 ` Saeed Mahameed
2018-03-22 12:38 ` Boris Pismenny
2018-03-22 13:03 ` Kirill Tkhai
2018-03-21 15:08 ` Dave Watson
2018-03-21 15:38 ` Boris Pismenny
2018-03-20 2:45 ` [PATCH net-next 07/14] net/tls: Support TLS device offload with IPv6 Saeed Mahameed
2018-03-20 2:45 ` [PATCH net-next 08/14] net/mlx5e: Move defines out of ipsec code Saeed Mahameed
2018-03-20 2:45 ` [PATCH net-next 09/14] net/mlx5: Accel, Add TLS tx offload interface Saeed Mahameed
2018-03-20 2:45 ` [PATCH net-next 10/14] net/mlx5e: TLS, Add Innova TLS TX support Saeed Mahameed
2018-03-20 2:45 ` [PATCH net-next 11/14] net/mlx5e: TLS, Add Innova TLS TX offload data path Saeed Mahameed
2018-03-20 2:45 ` [PATCH net-next 12/14] net/mlx5e: TLS, Add error statistics Saeed Mahameed
2018-03-20 2:45 ` [PATCH net-next 13/14] MAINTAINERS: Update mlx5 innova driver maintainers Saeed Mahameed
2018-03-20 2:45 ` [PATCH net-next 14/14] MAINTAINERS: Update TLS maintainers Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321.123207.1873098520164488354.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=davejwatson@fb.com \
--cc=ilyal@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=rao.shoaib@oracle.com \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).