From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: okaya@codeaurora.org, netdev@vger.kernel.org,
timur@codeaurora.org, sulrich@codeaurora.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH REPOST v4 5/7] ixgbevf: keep writel() closer to wmb()
Date: Wed, 21 Mar 2018 17:54:27 -0400 (EDT) [thread overview]
Message-ID: <20180321.175427.1419929873765406157.davem@davemloft.net> (raw)
In-Reply-To: <1521668888.12746.32.camel@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 21 Mar 2018 14:48:08 -0700
> On Wed, 2018-03-21 at 14:56 -0400, Sinan Kaya wrote:
>> Remove ixgbevf_write_tail() in favor of moving writel() close to
>> wmb().
>>
>> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
>> Reviewed-by: Alexander Duyck <alexander.h.duyck@intel.com>
>> ---
>> drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 5 -----
>> drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++--
>> 2 files changed, 2 insertions(+), 7 deletions(-)
>
> This patch fails to compile because there is a call to
> ixgbevf_write_tail() which you missed cleaning up.
For a change with delicate side effects, it doesn't create much
confidence if the code does not even compile.
Sinan, please put more care into the changes you are making.
Thank you.
next prev parent reply other threads:[~2018-03-21 21:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 18:56 [PATCH REPOST v4 0/7] netdev: intel: Eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-21 18:56 ` [PATCH REPOST v4 1/7] i40e/i40evf: " Sinan Kaya
2018-03-21 18:56 ` [PATCH REPOST v4 2/7] ixgbe: eliminate " Sinan Kaya
2018-03-21 18:56 ` [PATCH REPOST v4 3/7] igbvf: " Sinan Kaya
2018-03-21 18:56 ` [PATCH REPOST v4 4/7] igb: " Sinan Kaya
2018-03-21 18:56 ` [PATCH REPOST v4 5/7] ixgbevf: keep writel() closer to wmb() Sinan Kaya
2018-03-21 21:48 ` Jeff Kirsher
2018-03-21 21:51 ` okaya
2018-03-21 21:53 ` [Intel-wired-lan] " Alexander Duyck
2018-03-21 21:54 ` David Miller [this message]
2018-03-21 22:14 ` okaya
2018-03-21 18:56 ` [PATCH REPOST v4 6/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-21 18:56 ` [PATCH REPOST v4 7/7] fm10k: Eliminate " Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321.175427.1419929873765406157.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=sulrich@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).