netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Atul Gupta <atul.gupta@chelsio.com>
Cc: kbuild-all@01.org, davem@davemloft.net,
	herbert@gondor.apana.org.au, davejwatson@fb.com,
	sd@queasysnail.net, sbrivio@redhat.com,
	linux-crypto@vger.kernel.org, netdev@vger.kernel.org,
	ganeshgr@chelsio.com
Subject: Re: [PATCH v12 net-next 12/12] crypto: chtls - Makefile Kconfig
Date: Wed, 21 Mar 2018 02:06:18 +0800	[thread overview]
Message-ID: <201803210232.HIGWQmKl%fengguang.wu@intel.com> (raw)
In-Reply-To: <1521467745-23201-13-git-send-email-atul.gupta@chelsio.com>

Hi Atul,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20180309]
[also build test WARNING on v4.16-rc6]
[cannot apply to v4.16-rc4 v4.16-rc3 v4.16-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Atul-Gupta/Chelsio-Inline-TLS/20180320-101600
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   drivers/crypto/chelsio/chtls/chtls_main.c:319:14: sparse: undefined identifier 'CXGB4_STATE_FATAL_ERROR'
>> drivers/crypto/chelsio/chtls/chtls_main.c:319:14: sparse: incompatible types for 'case' statement
   drivers/crypto/chelsio/chtls/chtls_main.c:319:14: sparse: Expected constant expression in case statement
   drivers/crypto/chelsio/chtls/chtls_main.c: In function 'chtls_uld_state_change':
   drivers/crypto/chelsio/chtls/chtls_main.c:319:7: error: 'CXGB4_STATE_FATAL_ERROR' undeclared (first use in this function); did you mean 'CXGB4_STATE_DETACH'?
     case CXGB4_STATE_FATAL_ERROR:
          ^~~~~~~~~~~~~~~~~~~~~~~
          CXGB4_STATE_DETACH
   drivers/crypto/chelsio/chtls/chtls_main.c:319:7: note: each undeclared identifier is reported only once for each function it appears in
--
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1555:40: sparse: cast to restricted __be16
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1555:40: sparse: cast to restricted __be16
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1555:40: sparse: cast to restricted __be16
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1555:40: sparse: cast to restricted __be16
   drivers/crypto/chelsio/chtls/chtls_cm.c:1556:31: sparse: cast to restricted __be16
   drivers/crypto/chelsio/chtls/chtls_cm.c:1556:31: sparse: cast to restricted __be16
   drivers/crypto/chelsio/chtls/chtls_cm.c:1556:31: sparse: cast to restricted __be16
   drivers/crypto/chelsio/chtls/chtls_cm.c:1556:31: sparse: cast to restricted __be16
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1980:29: sparse: incorrect type in initializer (different base types) @@    expected restricted __be32 [usertype] credits @@    got unsignerestricted __be32 [usertype] credits @@
   drivers/crypto/chelsio/chtls/chtls_cm.c:1980:29:    expected restricted __be32 [usertype] credits
   drivers/crypto/chelsio/chtls/chtls_cm.c:1980:29:    got unsigned char [unsigned] [usertype] credits
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1982:25: sparse: invalid assignment: +=
   drivers/crypto/chelsio/chtls/chtls_cm.c:1982:25:    left side has type unsigned int
   drivers/crypto/chelsio/chtls/chtls_cm.c:1982:25:    right side has type restricted __be32
   drivers/crypto/chelsio/chtls/chtls_cm.c:1992:49: sparse: invalid assignment: -=
   drivers/crypto/chelsio/chtls/chtls_cm.c:1992:49:    left side has type unsigned int
   drivers/crypto/chelsio/chtls/chtls_cm.c:1992:49:    right side has type restricted __be32
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1995:21: sparse: restricted __be32 degrades to integer
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1995:21: sparse: restricted __wsum degrades to integer
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1996:36: sparse: bad assignment (-=) to restricted __wsum
>> drivers/crypto/chelsio/chtls/chtls_cm.c:2000:25: sparse: bad assignment (-=) to restricted __be32
>> drivers/crypto/chelsio/chtls/chtls_cm.c:1048:9: sparse: context imbalance in 'chtls_recv_sock' - unexpected unlock
--
>> drivers/crypto/chelsio/chtls/chtls_io.c:919:16: sparse: incorrect type in return expression (different base types) @@    expected unsigned short @@    got restricted __beunsigned short @@
   drivers/crypto/chelsio/chtls/chtls_io.c:919:16:    expected unsigned short
   drivers/crypto/chelsio/chtls/chtls_io.c:919:16:    got restricted __be16 [usertype] <noident>

vim +/case +319 drivers/crypto/chelsio/chtls/chtls_main.c

29f9f684 Atul Gupta 2018-03-19  307  
29f9f684 Atul Gupta 2018-03-19  308  static int chtls_uld_state_change(void *handle, enum cxgb4_state new_state)
29f9f684 Atul Gupta 2018-03-19  309  {
29f9f684 Atul Gupta 2018-03-19  310  	struct chtls_dev *cdev = handle;
29f9f684 Atul Gupta 2018-03-19  311  
29f9f684 Atul Gupta 2018-03-19  312  	switch (new_state) {
29f9f684 Atul Gupta 2018-03-19  313  	case CXGB4_STATE_UP:
29f9f684 Atul Gupta 2018-03-19  314  		chtls_register_dev(cdev);
29f9f684 Atul Gupta 2018-03-19  315  		break;
29f9f684 Atul Gupta 2018-03-19  316  	case CXGB4_STATE_DOWN:
29f9f684 Atul Gupta 2018-03-19  317  		break;
29f9f684 Atul Gupta 2018-03-19  318  	case CXGB4_STATE_START_RECOVERY:
29f9f684 Atul Gupta 2018-03-19 @319  	case CXGB4_STATE_FATAL_ERROR:
29f9f684 Atul Gupta 2018-03-19  320  		break;
29f9f684 Atul Gupta 2018-03-19  321  	case CXGB4_STATE_DETACH:
29f9f684 Atul Gupta 2018-03-19  322  		mutex_lock(&cdev_mutex);
29f9f684 Atul Gupta 2018-03-19  323  		list_del(&cdev->list);
29f9f684 Atul Gupta 2018-03-19  324  		mutex_unlock(&cdev_mutex);
29f9f684 Atul Gupta 2018-03-19  325  		chtls_free_uld(cdev);
29f9f684 Atul Gupta 2018-03-19  326  		break;
29f9f684 Atul Gupta 2018-03-19  327  	}
29f9f684 Atul Gupta 2018-03-19  328  	return 0;
29f9f684 Atul Gupta 2018-03-19  329  }
29f9f684 Atul Gupta 2018-03-19  330  

:::::: The code at line 319 was first introduced by commit
:::::: 29f9f68416a9775029d6cc8135cf3f01995dd9f4 crypto: chtls - Register chtls with net tls

:::::: TO: Atul Gupta <atul.gupta@chelsio.com>
:::::: CC: 0day robot <fengguang.wu@intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

  parent reply	other threads:[~2018-03-20 18:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-19 13:55 [PATCH v12 net-next 00/12] Chelsio Inline TLS Atul Gupta
2018-03-19 13:55 ` [PATCH v12 net-next 01/12] tls: support for Inline tls record Atul Gupta
2018-03-19 16:57   ` Stefano Brivio
2018-03-20 17:53   ` kbuild test robot
2018-03-20 17:53   ` [RFC PATCH] tls: create_ctx() can be static kbuild test robot
2018-03-19 13:55 ` [PATCH v12 net-next 02/12] ethtool: enable Inline TLS in HW Atul Gupta
2018-03-19 13:55 ` [PATCH v12 net-next 03/12] cxgb4: Inline TLS FW Interface Atul Gupta
2018-03-19 13:55 ` [PATCH v12 net-next 04/12] cxgb4: LLD driver changes to support TLS Atul Gupta
2018-03-19 13:55 ` [PATCH v12 net-next 05/12] crypto: chcr - Inline TLS Key Macros Atul Gupta
2018-03-19 13:55 ` [PATCH v12 net-next 06/12] crypto: chtls - structure and macro for Inline TLS Atul Gupta
2018-03-19 17:02   ` Stefano Brivio
2018-03-19 13:55 ` [PATCH v12 net-next 07/12] crypto: chtls - Program the TLS session Key Atul Gupta
2018-03-19 13:55 ` [PATCH v12 net-next 08/12] crypto : chtls - CPL handler definition Atul Gupta
2018-03-19 13:55 ` [PATCH v12 net-next 09/12] crypto: chtls - Inline TLS record Tx Atul Gupta
2018-03-19 16:57   ` Stefano Brivio
2018-03-19 13:55 ` [PATCH v12 net-next 10/12] crypto: chtls - Inline TLS record Rx Atul Gupta
2018-03-19 17:01   ` Stefano Brivio
2018-03-19 13:55 ` [PATCH v12 net-next 11/12] crypto: chtls - Register chtls with net tls Atul Gupta
2018-03-19 13:55 ` [PATCH v12 net-next 12/12] crypto: chtls - Makefile Kconfig Atul Gupta
2018-03-20 16:28   ` kbuild test robot
2018-03-20 18:06   ` kbuild test robot [this message]
2018-03-19 16:57 ` [PATCH v12 net-next 00/12] Chelsio Inline TLS Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201803210232.HIGWQmKl%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=atul.gupta@chelsio.com \
    --cc=davejwatson@fb.com \
    --cc=davem@davemloft.net \
    --cc=ganeshgr@chelsio.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kbuild-all@01.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sbrivio@redhat.com \
    --cc=sd@queasysnail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).