From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:59158 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751286AbeCVSbJ (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 22 Mar 2018 14:31:09 -0400
Date: Thu, 22 Mar 2018 14:31:04 -0400 (EDT)
Message-Id: <20180322.143104.2174553329772161672.davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: sd@queasysnail.net, dsahern@gmail.com, dwindsor@gmail.com,
        elena.reshetova@intel.com, Jason@zx2c4.com,
        mschiffer@universe-factory.net, johannes.berg@intel.com,
        felix.walter@cloudandheat.com, girish.moodalbail@oracle.com,
        netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] macsec: missing dev_put() on error in macsec_newlink()
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180321080900.GA9826@mwanda>
References: <20180321080900.GA9826@mwanda>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 21 Mar 2018 11:09:01 +0300

> We moved the dev_hold(real_dev); call earlier in the function but forgot
> to update the error paths.
> 
> Fixes: 0759e552bce7 ("macsec: fix negative refcnt on parent link")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied and queued up for -stable, thanks Dan.