From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: f.fainelli@gmail.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [RFC PATCH] etherdevice.h: net/core: Add ether_addrs.c and global ether_<foo>_addr
Date: Thu, 22 Mar 2018 14:33:24 -0400 (EDT) [thread overview]
Message-ID: <20180322.143324.294736014572721617.davem@davemloft.net> (raw)
In-Reply-To: <1358caea6069381c231ae9bf6ffb7126cca04321.1521622752.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Wed, 21 Mar 2018 02:03:37 -0700
> There are multiple instances of static const arrays for broadcast
> and zero ethernet addresses used for various purposes.
>
> Add const u8 ether_<foo>_addr[ETH_ALEN] globals to consolidate these uses.
>
> Miscellanea:
>
> o Move and rename the eth_reserved_addr_base declaration to this file
> and declare it extern to avoid possible multiple static definitions
> o Add compilation to the Makefile
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>
> Not sure this is the best place for this. Better ideas welcomed.
Well, for one thing you will need to export the symbols.
As for location, anything referencing these symbols or calling helpers
which do should depend upon ethernet.
prev parent reply other threads:[~2018-03-22 18:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 20:00 rfc: treewide replace local ethernet broadcast char arrays with a global ? Joe Perches
2018-03-20 20:07 ` Florian Fainelli
2018-03-20 20:25 ` Joe Perches
2018-03-21 9:03 ` [RFC PATCH] etherdevice.h: net/core: Add ether_addrs.c and global ether_<foo>_addr Joe Perches
2018-03-22 18:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180322.143324.294736014572721617.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).