From: Andrew Lunn <andrew@lunn.ch>
To: Vicen?iu Galanopulo <vicentiu.galanopulo@nxp.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [RFC PATCH] net: phy: Added device tree binding for dev-addr and dev-addr code check-up and usage
Date: Thu, 22 Mar 2018 16:43:26 +0100 [thread overview]
Message-ID: <20180322154326.GA11793@lunn.ch> (raw)
In-Reply-To: <HE1PR0402MB3578B23A4DEB394DECB68876EEAA0@HE1PR0402MB3578.eurprd04.prod.outlook.com>
> Just to make sure I understand. Do you want me to change the
> signature of all of_mdiobus_register_phy(), get_phy_device(),
> get_phy_id() and get_phy_c45_ids() and include the dev_addr
> parameter obtained from the device tree? (a propagation of this
> parameter across all functions all the way to
> get_phy_c45_devs_in_pkg?)
Humm, i thought about this some more...
When calling mdio_read/mdio_write with C45 addresses, we pack both
parts in addr, and mask in MII_ADDR_C45. Try playing with that idea.
It might be less messy.
Andrew
prev parent reply other threads:[~2018-03-22 15:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 13:46 [RFC PATCH] net: phy: Added device tree binding for dev-addr and dev-addr code check-up and usage Vicentiu Galanopulo
2018-03-20 14:30 ` Andrew Lunn
[not found] ` <HE1PR0402MB3578B23A4DEB394DECB68876EEAA0@HE1PR0402MB3578.eurprd04.prod.outlook.com>
2018-03-22 15:43 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180322154326.GA11793@lunn.ch \
--to=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=vicentiu.galanopulo@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).