From: David Miller <davem@davemloft.net>
To: nikolay@cumulusnetworks.com
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
bridge@lists.linux-foundation.org, 3chas3@gmail.com
Subject: Re: [PATCH net-next] net: bridge: fix direct access to bridge vlan_enabled and use helper
Date: Fri, 23 Mar 2018 12:41:33 -0400 (EDT) [thread overview]
Message-ID: <20180323.124133.2009910638975659955.davem@davemloft.net> (raw)
In-Reply-To: <1521822426-18563-1-git-send-email-nikolay@cumulusnetworks.com>
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Date: Fri, 23 Mar 2018 18:27:06 +0200
> We need to use br_vlan_enabled() helper otherwise we'll break builds
> without bridge vlans:
> net/bridge//br_if.c: In function ‘br_mtu’:
> net/bridge//br_if.c:458:8: error: ‘const struct net_bridge’ has no
> member named ‘vlan_enabled’
> if (br->vlan_enabled)
> ^
> net/bridge//br_if.c:462:1: warning: control reaches end of non-void
> function [-Wreturn-type]
> }
> ^
> scripts/Makefile.build:324: recipe for target 'net/bridge//br_if.o'
> failed
>
> Fixes: 419d14af9e07 ("bridge: Allow max MTU when multiple VLANs present")
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Applied, thanks for responding to this issue so quickly.
prev parent reply other threads:[~2018-03-23 16:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 15:34 [PATCH net-next] bridge: Allow max MTU when multiple VLANs present Chas Williams
2018-03-22 20:21 ` Nikolay Aleksandrov
2018-03-23 4:53 ` Roopa Prabhu
2018-03-29 16:49 ` Roopa Prabhu
2018-03-30 1:02 ` Toshiaki Makita
2018-03-30 19:54 ` Chas Williams
2018-04-02 15:08 ` Roopa Prabhu
2018-04-02 15:26 ` Chas Williams
2018-04-03 6:13 ` Roopa Prabhu
2018-04-03 10:14 ` Chas Williams
2018-03-23 16:17 ` David Miller
2018-03-23 16:20 ` Nikolay Aleksandrov
2018-03-23 21:50 ` Chas Williams
2018-03-23 16:27 ` [PATCH net-next] net: bridge: fix direct access to bridge vlan_enabled and use helper Nikolay Aleksandrov
2018-03-23 16:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323.124133.2009910638975659955.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=3chas3@gmail.com \
--cc=bridge@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).