From: David Miller <davem@davemloft.net>
To: idosch@mellanox.com
Cc: netdev@vger.kernel.org, jiri@mellanox.com, lucien.xin@gmail.com,
mlxsw@mellanox.com
Subject: Re: [PATCH net 0/3] mlxsw: Handle changes to MTU in GRE tunnels
Date: Fri, 23 Mar 2018 12:56:31 -0400 (EDT) [thread overview]
Message-ID: <20180323.125631.1663564310512844945.davem@davemloft.net> (raw)
In-Reply-To: <20180322175335.26232-1-idosch@mellanox.com>
From: Ido Schimmel <idosch@mellanox.com>
Date: Thu, 22 Mar 2018 19:53:32 +0200
> Petr says:
>
> When offloading GRE tunnels, the MTU setting is kept fixed after the
> initial offload even as the slow-path configuration changed. Worse: the
> offloaded MTU setting is actually just a transient value set at the time
> of NETDEV_REGISTER of the tunnel. As of commit ffc2b6ee4174 ("ip_gre:
> fix IFLA_MTU ignored on NEWLINK"), that transient value is zero, and
> unless there's e.g. a VRF migration that prompts re-offload, it stays at
> zero, and all GRE packets end up trapping.
>
> Thus, in patch #1, change the way the MTU is changed post-registration,
> so that the full event protocol is observed. That way the drivers get to
> see the change and have a chance to react.
>
> In the remaining two patches, implement support for MTU change in mlxsw
> driver.
Series applied, thanks.
prev parent reply other threads:[~2018-03-23 16:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 17:53 [PATCH net 0/3] mlxsw: Handle changes to MTU in GRE tunnels Ido Schimmel
2018-03-22 17:53 ` [PATCH net 1/3] ip_tunnel: Emit events for post-register MTU changes Ido Schimmel
2018-03-22 17:53 ` [PATCH net 2/3] mlxsw: spectrum_router: Move mlxsw_sp_rif_ipip_lb_op() Ido Schimmel
2018-03-22 17:53 ` [PATCH net 3/3] mlxsw: spectrum_router: Handle MTU change of GRE netdevs Ido Schimmel
2018-03-23 16:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323.125631.1663564310512844945.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=lucien.xin@gmail.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).