From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:43860 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752405AbeCWQ4g (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 23 Mar 2018 12:56:36 -0400
Date: Fri, 23 Mar 2018 12:56:31 -0400 (EDT)
Message-Id: <20180323.125631.1663564310512844945.davem@davemloft.net>
To: idosch@mellanox.com
Cc: netdev@vger.kernel.org, jiri@mellanox.com, lucien.xin@gmail.com,
        mlxsw@mellanox.com
Subject: Re: [PATCH net 0/3] mlxsw: Handle changes to MTU in GRE tunnels
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180322175335.26232-1-idosch@mellanox.com>
References: <20180322175335.26232-1-idosch@mellanox.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Ido Schimmel <idosch@mellanox.com>
Date: Thu, 22 Mar 2018 19:53:32 +0200

> Petr says:
> 
> When offloading GRE tunnels, the MTU setting is kept fixed after the
> initial offload even as the slow-path configuration changed. Worse: the
> offloaded MTU setting is actually just a transient value set at the time
> of NETDEV_REGISTER of the tunnel. As of commit ffc2b6ee4174 ("ip_gre:
> fix IFLA_MTU ignored on NEWLINK"), that transient value is zero, and
> unless there's e.g. a VRF migration that prompts re-offload, it stays at
> zero, and all GRE packets end up trapping.
> 
> Thus, in patch #1, change the way the MTU is changed post-registration,
> so that the full event protocol is observed. That way the drivers get to
> see the change and have a chance to react.
> 
> In the remaining two patches, implement support for MTU change in mlxsw
> driver.

Series applied, thanks.