From: David Miller <davem@davemloft.net>
To: saeedm@mellanox.com
Cc: netdev@vger.kernel.org, davejwatson@fb.com, borisp@mellanox.com,
ilyal@mellanox.com, aviadye@mellanox.com
Subject: Re: [PATCH V3 net-next 01/14] tcp: Add clean acked data hook
Date: Fri, 23 Mar 2018 13:29:58 -0400 (EDT) [thread overview]
Message-ID: <20180323.132958.1398721012186355078.davem@davemloft.net> (raw)
In-Reply-To: <20180322223351.31801-2-saeedm@mellanox.com>
From: Saeed Mahameed <saeedm@mellanox.com>
Date: Thu, 22 Mar 2018 15:33:38 -0700
> +#if IS_ENABLED(CONFIG_TLS_DEVICE)
> +DEFINE_STATIC_KEY_FALSE(clean_acked_data_enabled);
> +EXPORT_SYMBOL_GPL(clean_acked_data_enabled);
> +#endif
Please mark this symbol static (otherwise it's name pollutes the global
name space, "clean_acked" what? for what subsystem? etc.)
And add two helper functions, icsk_clean_acked_enable() and
icsk_clean_acked_disable() which adjust the static key as
needed.
For the enable helper, you can pass in an icsk and the function
pointer, so that the helper can do the assignment and the
connection between the static key and registering on an icsk
is clear.
next prev parent reply other threads:[~2018-03-23 17:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 22:33 [PATCH V3 net-next 00/14] TLS offload, netdev & MLX5 support Saeed Mahameed
2018-03-22 22:33 ` [PATCH V3 net-next 01/14] tcp: Add clean acked data hook Saeed Mahameed
2018-03-23 17:29 ` David Miller [this message]
2018-03-22 22:33 ` [PATCH V3 net-next 02/14] net: Rename and export copy_skb_header Saeed Mahameed
2018-03-22 22:33 ` [PATCH V3 net-next 03/14] net: Add Software fallback infrastructure for socket dependent offloads Saeed Mahameed
2018-03-22 22:33 ` [PATCH V3 net-next 04/14] net: Add TLS offload netdev ops Saeed Mahameed
2018-03-22 22:33 ` [PATCH V3 net-next 05/14] net: Add TLS TX offload features Saeed Mahameed
2018-03-22 22:33 ` [PATCH V3 net-next 06/14] net/tls: Add generic NIC offload infrastructure Saeed Mahameed
2018-03-23 17:31 ` David Miller
2018-03-23 20:21 ` Shannon Nelson
2018-03-26 7:10 ` Boris Pismenny
2018-03-26 8:18 ` Shannon Nelson
2018-03-22 22:33 ` [PATCH V3 net-next 07/14] net/tls: Support TLS device offload with IPv6 Saeed Mahameed
2018-03-22 22:33 ` [PATCH V3 net-next 08/14] net/mlx5e: Move defines out of ipsec code Saeed Mahameed
2018-03-22 22:33 ` [PATCH V3 net-next 09/14] net/mlx5: Accel, Add TLS tx offload interface Saeed Mahameed
2018-03-22 22:33 ` [PATCH V3 net-next 10/14] net/mlx5e: TLS, Add Innova TLS TX support Saeed Mahameed
2018-03-22 22:33 ` [PATCH V3 net-next 11/14] net/mlx5e: TLS, Add Innova TLS TX offload data path Saeed Mahameed
2018-03-22 22:33 ` [PATCH V3 net-next 12/14] net/mlx5e: TLS, Add error statistics Saeed Mahameed
2018-03-22 22:33 ` [PATCH V3 net-next 13/14] MAINTAINERS: Update mlx5 innova driver maintainers Saeed Mahameed
2018-03-22 22:33 ` [PATCH V3 net-next 14/14] MAINTAINERS: Update TLS maintainers Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323.132958.1398721012186355078.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=davejwatson@fb.com \
--cc=ilyal@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).