From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:44392 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751717AbeCWRaA (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 23 Mar 2018 13:30:00 -0400
Date: Fri, 23 Mar 2018 13:29:58 -0400 (EDT)
Message-Id: <20180323.132958.1398721012186355078.davem@davemloft.net>
To: saeedm@mellanox.com
Cc: netdev@vger.kernel.org, davejwatson@fb.com, borisp@mellanox.com,
        ilyal@mellanox.com, aviadye@mellanox.com
Subject: Re: [PATCH V3 net-next 01/14] tcp: Add clean acked data hook
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180322223351.31801-2-saeedm@mellanox.com>
References: <20180322223351.31801-1-saeedm@mellanox.com>
        <20180322223351.31801-2-saeedm@mellanox.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Saeed Mahameed <saeedm@mellanox.com>
Date: Thu, 22 Mar 2018 15:33:38 -0700

> +#if IS_ENABLED(CONFIG_TLS_DEVICE)
> +DEFINE_STATIC_KEY_FALSE(clean_acked_data_enabled);
> +EXPORT_SYMBOL_GPL(clean_acked_data_enabled);
> +#endif

Please mark this symbol static (otherwise it's name pollutes the global
name space, "clean_acked" what?  for what subsystem? etc.)

And add two helper functions, icsk_clean_acked_enable() and
icsk_clean_acked_disable() which adjust the static key as
needed.

For the enable helper, you can pass in an icsk and the function
pointer, so that the helper can do the assignment and the
connection between the static key and registering on an icsk
is clear.