From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:44418 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751717AbeCWRbJ (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 23 Mar 2018 13:31:09 -0400
Date: Fri, 23 Mar 2018 13:31:08 -0400 (EDT)
Message-Id: <20180323.133108.559607339395182037.davem@davemloft.net>
To: saeedm@mellanox.com
Cc: netdev@vger.kernel.org, davejwatson@fb.com, borisp@mellanox.com,
        ilyal@mellanox.com, aviadye@mellanox.com
Subject: Re: [PATCH V3 net-next 06/14] net/tls: Add generic NIC offload
 infrastructure
From: David Miller <davem@davemloft.net>
In-Reply-To: <20180322223351.31801-7-saeedm@mellanox.com>
References: <20180322223351.31801-1-saeedm@mellanox.com>
        <20180322223351.31801-7-saeedm@mellanox.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Saeed Mahameed <saeedm@mellanox.com>
Date: Thu, 22 Mar 2018 15:33:43 -0700

> diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c
> new file mode 100644
> index 000000000000..34555ac0b959
> --- /dev/null
> +++ b/net/tls/tls_device.c
 ...
> +static inline void tls_append_frag(struct tls_record_info *record,
> +				   struct page_frag *pfrag,
> +				   int size)

Do not use the inline keyword in foo.c files, please let the compiler
make that determination.

Please audit this entire submission for this problem.

Thank you.