From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from shards.monkeyblade.net ([184.105.139.130]:50584 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbeCXBy0 (ORCPT ); Fri, 23 Mar 2018 21:54:26 -0400 Date: Fri, 23 Mar 2018 21:54:24 -0400 (EDT) Message-Id: <20180323.215424.941284381400962799.davem@davemloft.net> To: dcaratti@redhat.com Cc: jiri@resnulli.us, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net/sched: act_vlan: declare push_vid with host byte order From: David Miller In-Reply-To: <65876774014962556e191e2a88e6eb02e0ece5a1.1521829106.git.dcaratti@redhat.com> References: <65876774014962556e191e2a88e6eb02e0ece5a1.1521829106.git.dcaratti@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: From: Davide Caratti Date: Fri, 23 Mar 2018 19:31:30 +0100 > use u16 in place of __be16 to suppress the following sparse warnings: > > net/sched/act_vlan.c:150:26: warning: incorrect type in assignment (different base types) > net/sched/act_vlan.c:150:26: expected restricted __be16 [usertype] push_vid > net/sched/act_vlan.c:150:26: got unsigned short > net/sched/act_vlan.c:151:21: warning: restricted __be16 degrades to integer > net/sched/act_vlan.c:208:26: warning: incorrect type in assignment (different base types) > net/sched/act_vlan.c:208:26: expected unsigned short [unsigned] [usertype] tcfv_push_vid > net/sched/act_vlan.c:208:26: got restricted __be16 [usertype] push_vid > > Signed-off-by: Davide Caratti Also applied, thanks Davide.