From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com ([209.85.128.195]:41296 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751288AbeCWG3o (ORCPT ); Fri, 23 Mar 2018 02:29:44 -0400 Received: by mail-wr0-f195.google.com with SMTP id f14so10942748wre.8 for ; Thu, 22 Mar 2018 23:29:43 -0700 (PDT) Date: Fri, 23 Mar 2018 07:29:41 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: netdev@vger.kernel.org, davem@davemloft.net, idosch@mellanox.com, mlxsw@mellanox.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, michael.chan@broadcom.com, ganeshgr@chelsio.com, saeedm@mellanox.com, simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com, dirk.vandermerwe@netronome.com, alexander.h.duyck@intel.com, ogerlitz@mellanox.com, dsahern@gmail.com, vijaya.guvva@cavium.com, satananda.burla@cavium.com, raghu.vatsavayi@cavium.com, felix.manlunas@cavium.com, gospo@broadcom.com, sathya.perla@broadcom.com, vasundhara-v.volam@broadcom.com, tariqt@mellanox.com, eranbe@mellanox.com, jeffrey.t.kirsher@intel.com Subject: Re: [patch net-next RFC 10/12] nfp: flower: create port for flower vnic Message-ID: <20180323062941.GH2074@nanopsycho.orion> References: <20180322105522.8186-1-jiri@resnulli.us> <20180322105522.8186-11-jiri@resnulli.us> <20180322203828.5167c0ac@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180322203828.5167c0ac@cakuba.netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: Fri, Mar 23, 2018 at 04:38:28AM CET, jakub.kicinski@netronome.com wrote: >On Thu, 22 Mar 2018 11:55:20 +0100, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Signed-off-by: Jiri Pirko >> --- >> drivers/net/ethernet/netronome/nfp/flower/main.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.c b/drivers/net/ethernet/netronome/nfp/flower/main.c >> index aed8df0e9d41..1890af7e6196 100644 >> --- a/drivers/net/ethernet/netronome/nfp/flower/main.c >> +++ b/drivers/net/ethernet/netronome/nfp/flower/main.c >> @@ -427,10 +427,9 @@ static int nfp_flower_vnic_alloc(struct nfp_app *app, struct nfp_net *nn, >> goto err_invalid_port; >> } >> >> - eth_hw_addr_random(nn->dp.netdev); >> netif_keep_dst(nn->dp.netdev); >> >> - return 0; >> + return nfp_app_nic_vnic_alloc(app, nn, id); >> >> err_invalid_port: >> nn->port = nfp_port_alloc(app, NFP_PORT_INVALID, nn->dp.netdev); > >This will associate the PF netdev with physical port, incl. all ethtool >information. Im not sure we want to do that. phy_repr carries this >functionality. I was not sure originally what this port is. Okay, what I would like to see is another port flavour for "pf" and "vf". I guess that since the pf has the same pci address, it would fall under the same devlink instance. For vfs, which have each separate pci address, I would like to create devlink instance for each and associate with one devlink port flavour "vf".