netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Kirill Tkhai <ktkhai@virtuozzo.com>
Cc: davem@davemloft.net, Michal.Kalderon@cavium.com,
	Ariel.Elior@cavium.com, dledford@redhat.com, benve@cisco.com,
	1dgoodell@cisco.com, daniel@iogearbox.net,
	jakub.kicinski@netronome.com, ast@kernel.org,
	edumazet@google.com, linux@rasmusvillemoes.dk,
	john.fastabend@gmail.com, brouer@redhat.com, dsahern@gmail.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: Drop NETDEV_UNREGISTER_FINAL
Date: Fri, 23 Mar 2018 10:15:43 -0600	[thread overview]
Message-ID: <20180323161543.GA13033@ziepe.ca> (raw)
In-Reply-To: <152179796956.13076.17482079697536507473.stgit@localhost.localdomain>

On Fri, Mar 23, 2018 at 12:39:33PM +0300, Kirill Tkhai wrote:
> Last user is gone after bdf5bd7f2132 "rds: tcp: remove
> register_netdevice_notifier infrastructure.", so we can
> remove this netdevice command. This allows to delete
> rtnl_lock() in netdev_run_todo(), which is hot path for
> net namespace unregistration.
> 
> dev_change_net_namespace() and netdev_wait_allrefs()
> have rcu_barrier() before NETDEV_UNREGISTER_FINAL call,
> and the source commits say they were introduced to
> delemit the call with NETDEV_UNREGISTER, but this patch
> leaves them on the places, since they require additional
> analysis, whether we need in them for something else.
> 
> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
>  drivers/infiniband/hw/qedr/main.c |    4 ++--
>  include/linux/netdevice.h         |    1 -
>  include/rdma/ib_verbs.h           |    4 ++--
>  net/core/dev.c                    |    6 ------
>  4 files changed, 4 insertions(+), 11 deletions(-)

No problem to take the rdma part of this through netdev

Acked-by: Jason Gunthorpe <jgg@mellanox.com>

Jason

      reply	other threads:[~2018-03-23 16:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <152179793764.13076.13815355125332565598.stgit@localhost.localdomain>
2018-03-23  9:39 ` [PATCH net-next 2/2] net: Drop NETDEV_UNREGISTER_FINAL Kirill Tkhai
2018-03-23 16:15   ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180323161543.GA13033@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=1dgoodell@cisco.com \
    --cc=Ariel.Elior@cavium.com \
    --cc=Michal.Kalderon@cavium.com \
    --cc=ast@kernel.org \
    --cc=benve@cisco.com \
    --cc=brouer@redhat.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dledford@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=edumazet@google.com \
    --cc=jakub.kicinski@netronome.com \
    --cc=john.fastabend@gmail.com \
    --cc=ktkhai@virtuozzo.com \
    --cc=linux@rasmusvillemoes.dk \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).