From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com ([209.85.128.195]:38468 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbeCWQPv (ORCPT ); Fri, 23 Mar 2018 12:15:51 -0400 Received: by mail-wr0-f195.google.com with SMTP id l8so12684705wrg.5 for ; Fri, 23 Mar 2018 09:15:51 -0700 (PDT) Date: Fri, 23 Mar 2018 10:15:43 -0600 From: Jason Gunthorpe To: Kirill Tkhai Cc: davem@davemloft.net, Michal.Kalderon@cavium.com, Ariel.Elior@cavium.com, dledford@redhat.com, benve@cisco.com, 1dgoodell@cisco.com, daniel@iogearbox.net, jakub.kicinski@netronome.com, ast@kernel.org, edumazet@google.com, linux@rasmusvillemoes.dk, john.fastabend@gmail.com, brouer@redhat.com, dsahern@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net: Drop NETDEV_UNREGISTER_FINAL Message-ID: <20180323161543.GA13033@ziepe.ca> References: <152179793764.13076.13815355125332565598.stgit@localhost.localdomain> <152179796956.13076.17482079697536507473.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152179796956.13076.17482079697536507473.stgit@localhost.localdomain> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Mar 23, 2018 at 12:39:33PM +0300, Kirill Tkhai wrote: > Last user is gone after bdf5bd7f2132 "rds: tcp: remove > register_netdevice_notifier infrastructure.", so we can > remove this netdevice command. This allows to delete > rtnl_lock() in netdev_run_todo(), which is hot path for > net namespace unregistration. > > dev_change_net_namespace() and netdev_wait_allrefs() > have rcu_barrier() before NETDEV_UNREGISTER_FINAL call, > and the source commits say they were introduced to > delemit the call with NETDEV_UNREGISTER, but this patch > leaves them on the places, since they require additional > analysis, whether we need in them for something else. > > Signed-off-by: Kirill Tkhai > drivers/infiniband/hw/qedr/main.c | 4 ++-- > include/linux/netdevice.h | 1 - > include/rdma/ib_verbs.h | 4 ++-- > net/core/dev.c | 6 ------ > 4 files changed, 4 insertions(+), 11 deletions(-) No problem to take the rdma part of this through netdev Acked-by: Jason Gunthorpe Jason