From: kbuild test robot <fengguang.wu@intel.com>
To: Jon Maloy <jon.maloy@ericsson.com>
Cc: kbuild-all@01.org, netdev@vger.kernel.org,
Ying Xue <ying.xue@windriver.com>,
tipc-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH net-next] tipc: tipc_disc_addr_trial_msg() can be static
Date: Sat, 24 Mar 2018 03:47:42 +0800 [thread overview]
Message-ID: <20180323194742.GA68339@athens> (raw)
In-Reply-To: <201803240317.PGXU57zT%fengguang.wu@intel.com>
Fixes: 25b0b9c4e835 ("tipc: handle collisions of 32-bit node address hash values")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
discover.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/net/tipc/discover.c b/net/tipc/discover.c
index e765573..9f666e0 100644
--- a/net/tipc/discover.c
+++ b/net/tipc/discover.c
@@ -134,13 +134,13 @@ static void disc_dupl_alert(struct tipc_bearer *b, u32 node_addr,
/* tipc_disc_addr_trial(): - handle an address uniqueness trial from peer
*/
-bool tipc_disc_addr_trial_msg(struct tipc_discoverer *d,
- struct tipc_media_addr *maddr,
- struct tipc_bearer *b,
- u32 dst, u32 src,
- u32 sugg_addr,
- u8 *peer_id,
- int mtyp)
+static bool tipc_disc_addr_trial_msg(struct tipc_discoverer *d,
+ struct tipc_media_addr *maddr,
+ struct tipc_bearer *b,
+ u32 dst, u32 src,
+ u32 sugg_addr,
+ u8 *peer_id,
+ int mtyp)
{
struct net *net = d->net;
struct tipc_net *tn = tipc_net(net);
next prev parent reply other threads:[~2018-03-23 19:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 19:47 [net-next:master 1142/1149] net/tipc/discover.c:137:6: sparse: symbol 'tipc_disc_addr_trial_msg' was not declared. Should it be static? kbuild test robot
2018-03-23 19:47 ` kbuild test robot [this message]
2018-03-24 12:57 ` [RFC PATCH net-next] tipc: tipc_disc_addr_trial_msg() can be static Jon Maloy
2018-03-26 1:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323194742.GA68339@athens \
--to=fengguang.wu@intel.com \
--cc=jon.maloy@ericsson.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).