From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:41182 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752633AbeCXTAm (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 24 Mar 2018 15:00:42 -0400
Date: Sat, 24 Mar 2018 20:00:32 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org,
        davem@davemloft.net, idosch@mellanox.com,
        jakub.kicinski@netronome.com, mlxsw@mellanox.com,
        vivien.didelot@savoirfairelinux.com, michael.chan@broadcom.com,
        ganeshgr@chelsio.com, saeedm@mellanox.com,
        simon.horman@netronome.com, pieter.jansenvanvuuren@netronome.com,
        john.hurley@netronome.com, dirk.vandermerwe@netronome.com,
        alexander.h.duyck@intel.com, ogerlitz@mellanox.com,
        dsahern@gmail.com, vijaya.guvva@cavium.com,
        satananda.burla@cavium.com, raghu.vatsavayi@cavium.com,
        felix.manlunas@cavium.com, gospo@broadcom.com,
        sathya.perla@broadcom.com, vasundhara-v.volam@broadcom.com,
        tariqt@mellanox.com, eranbe@mellanox.com,
        jeffrey.t.kirsher@intel.com
Subject: Re: [patch net-next RFC 00/12] devlink: introduce port flavours and
 common phys_port_name generation
Message-ID: <20180324190032.GH31941@lunn.ch>
References: <20180322105522.8186-1-jiri@resnulli.us>
 <20180323134357.GG5145@lunn.ch>
 <20180323145935.GC2125@nanopsycho>
 <20180323152412.GC24361@lunn.ch>
 <20180324074551.GD1891@nanopsycho>
 <0B8BC202-9067-4D34-AC4F-79DC33B4E6F9@gmail.com>
 <20180324160749.GG1891@nanopsycho>
 <D017986F-35B3-4B33-B2FF-97103AA9964A@gmail.com>
 <20180324174248.GH1891@nanopsycho>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180324174248.GH1891@nanopsycho>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> >>>>>> >root@zii-devel-b:~# ./iproute2/devlink/devlink port 
> >>>>>> >mdio_bus/0.1:00/0: type eth netdev lan0 flavour physical number 0
> >>>>>> >mdio_bus/0.1:00/1: type eth netdev lan1 flavour physical number 1
> >>>>>> >mdio_bus/0.1:00/2: type eth netdev lan2 flavour physical number 2
> >>>>>> >mdio_bus/0.1:00/3: type notset
> >>>>>> >mdio_bus/0.1:00/4: type notset
> >>>>>> >mdio_bus/0.1:00/5: type notset flavour dsa number 5
> >>>>>> >mdio_bus/0.1:00/6: type notset flavour cpu number 6
> >>>>>> >mdio_bus/0.2:00/0: type eth netdev lan3 flavour physical number 0
> >>>>>> >mdio_bus/0.2:00/1: type eth netdev lan4 flavour physical number 1
> >>>>>> >mdio_bus/0.2:00/2: type eth netdev lan5 flavour physical number 2
> >>>>>> >mdio_bus/0.2:00/3: type notset
> >>>>>> >mdio_bus/0.2:00/4: type notset
> >>>>>> >mdio_bus/0.2:00/5: type notset flavour dsa number 5
> >>>>>> >mdio_bus/0.2:00/6: type notset flavour dsa number 6
> >>>>>> >mdio_bus/0.4:00/0: type eth netdev lan6 flavour physical number 0
> >>>>>> >mdio_bus/0.4:00/1: type eth netdev lan7 flavour physical number 1
> >>>>>> >mdio_bus/0.4:00/2: type eth netdev lan8 flavour physical number 2
> >>>>>> >mdio_bus/0.4:00/3: type eth netdev optical3 flavour physical

> >What is an appropriate attribute to use to return the physical port number within a given switch?
> 
> I don't think there's one out there. I tried to add it in this patchset.

Florian, do you need it to be unique per switch, or DSA cluster. The
current solution is clearly not unique across a cluster.

	Andrew