From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink Date: Sat, 24 Mar 2018 23:35:24 -0700 Message-ID: <20180324233524.41ecd368@cakuba.netronome.com> References: <20180322225757.10377-1-dsa@cumulusnetworks.com> <20180322225757.10377-8-dsa@cumulusnetworks.com> <20180323204749.52d30129@cakuba.netronome.com> <1b5db863-7949-e4a2-7f22-6dd79ecb8089@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, roopa@cumulusnetworks.com, shm@cumulusnetworks.com, jiri@mellanox.com, idosch@mellanox.com, David Ahern To: David Ahern Return-path: Received: from mail-pl0-f67.google.com ([209.85.160.67]:46006 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbeCYGf2 (ORCPT ); Sun, 25 Mar 2018 02:35:28 -0400 Received: by mail-pl0-f67.google.com with SMTP id n15-v6so9947915plp.12 for ; Sat, 24 Mar 2018 23:35:28 -0700 (PDT) In-Reply-To: <1b5db863-7949-e4a2-7f22-6dd79ecb8089@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, 24 Mar 2018 09:02:45 -0600, David Ahern wrote: > >> diff --git a/drivers/net/netdevsim/Makefile b/drivers/net/netdevsim/Makefile > >> index 09388c06171d..449b2a1a1800 100644 > >> --- a/drivers/net/netdevsim/Makefile > >> +++ b/drivers/net/netdevsim/Makefile > >> @@ -9,3 +9,7 @@ ifeq ($(CONFIG_BPF_SYSCALL),y) > >> netdevsim-objs += \ > >> bpf.o > >> endif > >> + > >> +ifneq ($(CONFIG_NET_DEVLINK),) > > > > Hm. Don't you need MAY_USE_DEVLINK dependency perhaps? > > mlxsw uses CONFIG_NET_DEVLINK in its Makefile. > > MAY_USE_DEVLINK seems to only be used in Kconfig files. Not clear to me > why it is needed at all. NETDEVSIM=y && DEVLINK=m