From: David Miller <davem@davemloft.net>
To: raghuramchary.jallipalli@microchip.com
Cc: netdev@vger.kernel.org, unglinuxdriver@microchip.com,
woojung.huh@microchip.com
Subject: Re: [PATCH v1 net] lan78xx: Set ASD in MAC_CR when EEE is enabled.
Date: Sun, 25 Mar 2018 21:07:07 -0400 (EDT) [thread overview]
Message-ID: <20180325.210707.1571877676175504785.davem@davemloft.net> (raw)
In-Reply-To: <20180323101808.6317-1-raghuramchary.jallipalli@microchip.com>
From: Raghuram Chary J <raghuramchary.jallipalli@microchip.com>
Date: Fri, 23 Mar 2018 15:48:08 +0530
> Description:
> EEE does not work with lan7800 when AutoSpeed is not set.
> (This can happen when EEPROM is not populated or configured incorrectly)
>
> Root-Cause:
> When EEE is enabled, the mac config register ASD is not set
> i.e. in default state, causing EEE fail.
>
> Fix:
> Set the register when eeprom is not present.
>
> Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver")
> Signed-off-by: Raghuram Chary J <raghuramchary.jallipalli@microchip.com>
> ---
> v0->v1:
> * Resolved the style related problems.
> * Removed 1/3 patch count from Subject line.
Applied, thanks.
prev parent reply other threads:[~2018-03-26 1:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 10:18 [PATCH v1 net] lan78xx: Set ASD in MAC_CR when EEE is enabled Raghuram Chary J
2018-03-26 1:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180325.210707.1571877676175504785.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=raghuramchary.jallipalli@microchip.com \
--cc=unglinuxdriver@microchip.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).