[net-next:master 1142/1149] net/tipc/discover.c:137:6: sparse: symbol 'tipc_disc_addr_trial_msg' was not declared. Should it be static?

[net-next:master 1142/1149] net/tipc/discover.c:137:6: sparse: symbol 'tipc_disc_addr_trial_msg' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   f452518c982e57538e6d49da0a2c80eef22087ab
commit: 25b0b9c4e835ffaa65b61c3efe2e28acf84d0259 [1142/1149] tipc: handle collisions of 32-bit node address hash values
reproduce:
        # apt-get install sparse
        git checkout 25b0b9c4e835ffaa65b61c3efe2e28acf84d0259
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> net/tipc/discover.c:137:6: sparse: symbol 'tipc_disc_addr_trial_msg' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[RFC PATCH net-next] tipc: tipc_disc_addr_trial_msg() can be static

[kbuild test robot]

Fixes: 25b0b9c4e835 ("tipc: handle collisions of 32-bit node address hash values")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 discover.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/net/tipc/discover.c b/net/tipc/discover.c
index e765573..9f666e0 100644
--- a/net/tipc/discover.c
+++ b/net/tipc/discover.c
@@ -134,13 +134,13 @@ static void disc_dupl_alert(struct tipc_bearer *b, u32 node_addr,
 
 /* tipc_disc_addr_trial(): - handle an address uniqueness trial from peer
  */
-bool tipc_disc_addr_trial_msg(struct tipc_discoverer *d,
-			      struct tipc_media_addr *maddr,
-			      struct tipc_bearer *b,
-			      u32 dst, u32 src,
-			      u32 sugg_addr,
-			      u8 *peer_id,
-			      int mtyp)
+static bool tipc_disc_addr_trial_msg(struct tipc_discoverer *d,
+				     struct tipc_media_addr *maddr,
+				     struct tipc_bearer *b,
+				     u32 dst, u32 src,
+				     u32 sugg_addr,
+				     u8 *peer_id,
+				     int mtyp)
 {
 	struct net *net = d->net;
 	struct tipc_net *tn = tipc_net(net);

RE: [RFC PATCH net-next] tipc: tipc_disc_addr_trial_msg() can be static

[Jon Maloy]

Acked-by: Jon Maloy jon.maloy@ericsson.com

Thanks, Fengguang

> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org] On Behalf Of kbuild test robot
> Sent: Friday, March 23, 2018 15:48
> To: Jon Maloy <jon.maloy@ericsson.com>
> Cc: kbuild-all@01.org; netdev@vger.kernel.org; Ying Xue
> <ying.xue@windriver.com>; tipc-discussion@lists.sourceforge.net; linux-
> kernel@vger.kernel.org
> Subject: [RFC PATCH net-next] tipc: tipc_disc_addr_trial_msg() can be static
> 
> 
> Fixes: 25b0b9c4e835 ("tipc: handle collisions of 32-bit node address hash
> values")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  discover.c |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/net/tipc/discover.c b/net/tipc/discover.c index e765573..9f666e0
> 100644
> --- a/net/tipc/discover.c
> +++ b/net/tipc/discover.c
> @@ -134,13 +134,13 @@ static void disc_dupl_alert(struct tipc_bearer *b,
> u32 node_addr,
> 
>  /* tipc_disc_addr_trial(): - handle an address uniqueness trial from peer
>   */
> -bool tipc_disc_addr_trial_msg(struct tipc_discoverer *d,
> -			      struct tipc_media_addr *maddr,
> -			      struct tipc_bearer *b,
> -			      u32 dst, u32 src,
> -			      u32 sugg_addr,
> -			      u8 *peer_id,
> -			      int mtyp)
> +static bool tipc_disc_addr_trial_msg(struct tipc_discoverer *d,
> +				     struct tipc_media_addr *maddr,
> +				     struct tipc_bearer *b,
> +				     u32 dst, u32 src,
> +				     u32 sugg_addr,
> +				     u8 *peer_id,
> +				     int mtyp)
>  {
>  	struct net *net = d->net;
>  	struct tipc_net *tn = tipc_net(net);

Re: [RFC PATCH net-next] tipc: tipc_disc_addr_trial_msg() can be static

[David Miller]

From: kbuild test robot <fengguang.wu@intel.com>
Date: Sat, 24 Mar 2018 03:47:42 +0800

> Fixes: 25b0b9c4e835 ("tipc: handle collisions of 32-bit node address hash values")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Applied.