From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH RFC net-next 7/7] netdevsim: Add simple FIB resource controller via devlink Date: Sun, 25 Mar 2018 12:53:22 -0700 Message-ID: <20180325125322.43db4c17@cakuba.netronome.com> References: <20180322225757.10377-1-dsa@cumulusnetworks.com> <20180322225757.10377-8-dsa@cumulusnetworks.com> <20180323204749.52d30129@cakuba.netronome.com> <1b5db863-7949-e4a2-7f22-6dd79ecb8089@cumulusnetworks.com> <20180324233524.41ecd368@cakuba.netronome.com> <2c80d538-6881-709a-58b9-e0dfb669fac3@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, roopa@cumulusnetworks.com, shm@cumulusnetworks.com, jiri@mellanox.com, idosch@mellanox.com, David Ahern To: David Ahern Return-path: Received: from mail-pg0-f66.google.com ([74.125.83.66]:34090 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049AbeCYTx0 (ORCPT ); Sun, 25 Mar 2018 15:53:26 -0400 Received: by mail-pg0-f66.google.com with SMTP id m15so6505274pgc.1 for ; Sun, 25 Mar 2018 12:53:26 -0700 (PDT) In-Reply-To: <2c80d538-6881-709a-58b9-e0dfb669fac3@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, 25 Mar 2018 08:27:42 -0600, David Ahern wrote: > On 3/25/18 12:35 AM, Jakub Kicinski wrote: > > On Sat, 24 Mar 2018 09:02:45 -0600, David Ahern wrote: > >>>> diff --git a/drivers/net/netdevsim/Makefile b/drivers/net/netdevsim/Makefile > >>>> index 09388c06171d..449b2a1a1800 100644 > >>>> --- a/drivers/net/netdevsim/Makefile > >>>> +++ b/drivers/net/netdevsim/Makefile > >>>> @@ -9,3 +9,7 @@ ifeq ($(CONFIG_BPF_SYSCALL),y) > >>>> netdevsim-objs += \ > >>>> bpf.o > >>>> endif > >>>> + > >>>> +ifneq ($(CONFIG_NET_DEVLINK),) > >>> > >>> Hm. Don't you need MAY_USE_DEVLINK dependency perhaps? > >> > >> mlxsw uses CONFIG_NET_DEVLINK in its Makefile. > >> > >> MAY_USE_DEVLINK seems to only be used in Kconfig files. Not clear to me > >> why it is needed at all. > > > > NETDEVSIM=y && DEVLINK=m > > > > ok. I purposely did not add DEVLINK as a dependency to netdevsim to make > the resource controller truly optional. Can add it if you prefer. Oh, no, I don't mind. I just thought NETDEVSIM=y DEVLINK=m case will break the build, but I haven't tested. If it works perfect, let's not add unnecessary dependencies :) (FWIW the MAY_USE_DEVLINK dep is basically depend on DEVLINK || DEVLINK=n, so one can still build without devlink but if devlink is a module netdevsim will also have to be.)